Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwritten in promotion.jl #72

Closed
vavrines opened this issue Aug 1, 2021 · 1 comment · Fixed by #73
Closed

overwritten in promotion.jl #72

vavrines opened this issue Aug 1, 2021 · 1 comment · Fixed by #73

Comments

@vavrines
Copy link

vavrines commented Aug 1, 2021

It seems that line 58 in promotion.jl

MP.promote_rule(::Type{Term{C,M1} where {C}}, ::Type{Term{T,M2}}) where {T,M1,M2} = (Term{C,promote_type(M1, M2)} where {C})

is a duplicate of 56

MP.promote_rule(::Type{Term{C,M1} where {C}}, ::Type{Term{T,M2}}) where {T,M1,M2} = (Term{C,promote_type(M1, M2)} where {C})

so it throws this warning during precompilation

WARNING: Method definition promote_rule(Type{TypedPolynomials.Term{C, M1} where C}, Type{TypedPolynomials.Term{T, M2}}) where {T, M1, M2} in module TypedPolynomials at /home2/vavrines/.julia/packages/TypedPolynomials/oORum/src/promotion.jl:58 overwritten at /home2/vavrines/.julia/packages/TypedPolynomials/oORum/src/promotion.jl:56.
  ** incremental compilation may be fatally broken for this module **
@blegat
Copy link
Member

blegat commented Aug 8, 2021

Indeed thanks!

@blegat blegat closed this as completed in #73 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants