Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables 1.8.0 breaks scitypes for MLJText #25

Closed
ablaom opened this issue Oct 5, 2022 · 1 comment
Closed

Tables 1.8.0 breaks scitypes for MLJText #25

ablaom opened this issue Oct 5, 2022 · 1 comment
Assignees
@ablaom

Comments

@ablaom
Copy link
Member

ablaom commented Oct 5, 2022

JuliaData/Tables.jl#306

n_grams = [
    Dict("Hi" => 1, "name" => 1),
    Dict("name" => 1, "Sam" => 1),
]

using Tables

julia> Tables.istable(n_grams) # Tables 1.7.0
false

julia> Tables.istable(n_grams) # Tables 1.8.0
true

using TextAnalysis, ScientificTypes

julia> scitype(n_grams) # Tables 1.7.0
AbstractVector{Multiset{Textual}} (alias for AbstractArray{Multiset{Textual}, 1})

julia> scitype(n_grams) # Tables 1.8.0
Table{Union{AbstractVector{Count}, AbstractVector{Union{Missing, Count}}}}
This was referenced Oct 5, 2022
Closed
Merged
@ablaom ablaom self-assigned this Oct 10, 2022
@ablaom
Copy link
Member Author

ablaom commented Oct 10, 2022

Above ScientificTypes PR should resolve this issue.

@ablaom ablaom closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ablaom ablaom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom