Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vector properties updatable as vectors #13

Open
bedeho opened this issue Sep 21, 2019 · 1 comment
Open

Make vector properties updatable as vectors #13

bedeho opened this issue Sep 21, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bedeho
Copy link
Member

bedeho commented Sep 21, 2019

Currently, the only way to update values is to write a full new value through update_entity_properties, this undercuts the point of having native vectors, as one could easily just encode them if on-chain awareness was not important. So let's introduce property value level operations like clear, insert_at, remove_at for all vectors.

Notice that this requires the introduction of a nonce, or a similar mechanism, per property value to avoid race update conditions.

@bedeho bedeho added the good first issue Good for newcomers label Sep 21, 2019
@siman
Copy link
Contributor

siman commented Sep 25, 2019

Sounds like a good idea for insert_at and remove_at.

As for clear it could be easily achieved by passing an empty vector or None to the vec- property via update_entity_properties

Also makes sense to support append.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants