-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[USERSNAP] Parse markdown in Posts, Applications, Profiles #2712
Comments
@talentdev0807 |
The component used at Joystream as WYSIWYG editor (CK Editor) has an open issue ckeditor/ckeditor5#2321 that is exactly about being able to paste md content to a text area and then seeing that text as html. I am not sure if Joystream Builders are in the position to fix any downstream components issues, such as the above. For now I am closing this issue as |
@singulart @talentdev0807 I tried to clarify the description a bit, but this issue is not about parsing markdown in CK editor. It's about using We mentioned CK Editor because it's hard to know which fields are markdown vs plain text (they're all |
When it comes to talk about , it is just for converting markdown to React JSX to display it on web page |
The input for existing posts should come from the QN / chain. My suggestion: If Markdown parser succeeds display that otherwise render with CK. |
@talentdev0807 if I understand correctly you mean that the text (in the screenshot for example) gets rendered through In any case I don't think rendering CKE is a viable solution, it would be confusing and if the text is escaped somewhere else CKE wouldn't render it well either... |
Text which comes to MarkdownPreview is escaped with backslash.
When i put normal markdown inside the MardkdownPreview component it works as exepected:
When I strip slashes using regexp it seems to be working as expected: @thesan wdyt? |
|
@polikosi it certainly did make total sense at the time of writing it up and grooming, but cannot connect the dots now. Pls skip this point and I will mark this as a strike-through and out of scope. Thank you for asking! |
Scope
Add markdown interpretation in all fields initially created with CK Editor (Description/ Forum posts etc)
This should cover all text fields, but specifically:
Widgets with text shown in themOut of scope:
Context
Taken at: https://dao.joystream.org/#/working-groups/openings/operationsWorkingGroupAlpha-1
Fields:
Download original image
Browser: Chrome 99 (Linux)
Screen size: 1920x1080
Browser size: 2390x1216
Labels: enhancement
Open #159 in Usersnap
Powered by Usersnap.
The text was updated successfully, but these errors were encountered: