Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 22 for CI builds. #468

Merged
merged 4 commits into from
May 10, 2024
Merged

Use Java 22 for CI builds. #468

merged 4 commits into from
May 10, 2024

Conversation

DavidWhitlock
Copy link
Collaborator

Resolve #465 by using Java 22 for GitHub Continuous Integration builds.

@DavidWhitlock
Copy link
Collaborator Author

Looks like the CI build is failing because

[INFO]      [java] The following errors occurred during analysis:
[INFO]      [java]   Error scanning java/lang/Object for referenced classes
[INFO]      [java]     java.lang.IllegalArgumentException: Unsupported class file major version 66
[INFO]      [java]       At org.objectweb.asm.ClassReader.<init>(ClassReader.java:199)
[INFO]      [java]       At org.objectweb.asm.ClassReader.<init>(ClassReader.java:180)
[INFO]      [java]       At org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
[INFO]      [java]       At edu.umd.cs.findbugs.asm.FBClassReader.<init>(FBClassReader.java:35)
[INFO]      [java]       At edu.umd.cs.findbugs.classfile.engine.asm.ClassReaderAnalysisEngine.analyze(ClassReaderAnalysisEngine.java:48)
[INFO]      [java]       At edu.umd.cs.findbugs.classfile.engine.asm.ClassReaderAnalysisEngine.analyze(ClassReaderAnalysisEngine.java:34)
[INFO]      [java]       At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:261)
[INFO]      [java]       At edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:75)
[INFO]      [java]       At edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
[INFO]      [java]       At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:261)
[INFO]      [java]       At edu.umd.cs.findbugs.FindBugs2.buildReferencedClassSet(FindBugs2.java:806)
[INFO]      [java]       At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:249)
[INFO]      [java]       At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395)
[INFO]      [java]       At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1231)

Interestingly enough, it doesn't reproduce for me locally with Java 22.

And the version of the spotbugs plugin that is used locally is 4.8.4.0, but on the CI build, it's 4.7.3.4. I wonder why that is.

@DavidWhitlock
Copy link
Collaborator Author

DavidWhitlock commented May 9, 2024

Oh, it appears that the 1.0.0 version of the top-level POM that was deployed to Maven central doesn't have the newer plugin versions.

https://repo.maven.apache.org/maven2/io/github/davidwhitlock/joy/joy/1.0.0/joy-1.0.0.pom

I wonder how that happened. I guess I'll have to deploy a new version of the top-level POM. Swell.

Sure enough, I deleted the top-level POM from my local repository and the build failed after downloading the one from Maven Central.

@DavidWhitlock DavidWhitlock merged commit 825b4ec into main May 10, 2024
5 checks passed
@DavidWhitlock DavidWhitlock deleted the issue-465/java-22 branch May 10, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with Java 22 for GitHub integration.
1 participant