Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Don't transpile tests #623

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jul 30, 2023 · 1 comment
Closed
3 tasks done

🛠 Tooling: Don't transpile tests #623

JoshuaKGoldberg opened this issue Jul 30, 2023 · 1 comment
Labels
area: tooling Managing the repository's maintenance status: in discussion Not yet ready for implementation or a pull request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

@bradzacher mentioned in typescript-eslint/typescript-eslint#7056 (comment):

To me it seems weird to transpile tests - as the project grows this will slow down the build step a lot - which is why we are cautious to exclude them in this project. Imagine if our massive blob of fixtures was included in the transpiration then ignored by the publish - it'd be very slow!

Typechecking them - 100%, but transpiling them - no way!

Agreed. It's suboptimal that this repo transpiles tests unnecessarily. How to avoid it?

I'd rather not add multiple TSConfig files... maybe the repo should use tsup the way consumers such as https://github.com/JoshuaKGoldberg/ts-api-utils do? That would make it easier for consumers to add in dual CJS+ESM emit...

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: in discussion Not yet ready for implementation or a pull request labels Jul 30, 2023
@JoshuaKGoldberg
Copy link
Owner Author

Fixed by #640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: in discussion Not yet ready for implementation or a pull request
Projects
None yet
Development

No branches or pull requests

1 participant