Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to python 3.10 (and fix code cov issue) #33

Closed
JonathanCasey opened this issue Oct 25, 2021 · 0 comments · Fixed by #34
Closed

Migrate to python 3.10 (and fix code cov issue) #33

JonathanCasey opened this issue Oct 25, 2021 · 0 comments · Fixed by #34

Comments

@JonathanCasey
Copy link
Owner

Why not?

Can start or-ing dicts together, which is nice.

...but it might fix the code coverage issue encountered on #32. By executing pytest -k 'test__filter_tasks_by_datetime' --cov-report=term-missing --cov=asana_extensions/asana and looking at the line numbers in the Missing column for the utils.py module, it can be seen that there is a miss in the _filter_tasks_by_datetime(). This seems to be related to this in pytest-cov, which references this issue in coveragepy and hints that this is a problem with an underlying mechanism in python itself, which coveragepy asserts on that issue (which was opened in 2012!) that it just got fixed THIS YEAR!

Will give it a try. If it fails, will find a work around to restore 100% test coverage. It seems likely putting anything meaningless in the else before the continue should work, as it seems like an optimization issue that is mismatched with how coverage is determined. A print() statement did the trick in a simple test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant