Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbp #1

Closed
widbuntu opened this issue Jan 2, 2025 · 6 comments
Closed

pbp #1

widbuntu opened this issue Jan 2, 2025 · 6 comments

Comments

@widbuntu
Copy link

widbuntu commented Jan 2, 2025

Great stuff. Any thoughts on adding play by play?
https://stats.ncaa.org/contests/6080706/play_by_play

@JeffreyRStevens
Copy link
Owner

JeffreyRStevens commented Jan 3, 2025

@widbuntu

  1. Thanks! How did you find this? I just make it public two days ago and haven't publicized it yet.
  2. OK, in the new version I pushed today (0.2.0), I have added a new function match_pbp(). All it does at the moment is extracts a data table for each set's play-by-play information. But I'm happy to hear ideas on how to better parse this data.
  3. I've also added two new functions for match-level data. find_team_contests() gets the contest IDs needed to find the match-level data. player_match-stats() extracts the player statistics for both teams in the match. Neither of these is extensively tested though (nor is match_pbp()).
  4. FYI--I have renamed team_player_stats() to player_season_stats() (and deprecated it).

Any suggestions are welcome!

@widbuntu
Copy link
Author

widbuntu commented Jan 3, 2025

I had put this together a few years ago: https://github.com/tyler-widdison/ncaavolleyballR. Although I think many things are out dated now that I had done.
For example I used this for the teams: https://stats.ncaa.org/team/search.
Where I could use this:
https://web3.ncaa.org/directory/api/directory/memberList?type=12&sportCode=WVB
or this
https://stats.ncaa.org/game_upload/team_codes.
It's great to see some new options which are up to date 👍

@JeffreyRStevens
Copy link
Owner

That's awesome! Dang, wish I would have known about your package earlier---both in terms of overlap in functions and the name. Are you thinking about updating and submitting to CRAN? I'm deciding whether to rename my package now.
[Note to self: check GitHub not just CRAN when developing new packages!]

Also, I've pushed a new version (0.3.0) with much better pbp output more similar to yours. The pbp descriptions can be quite messy, so I need to test it a bit more to capture all of the events.

Both the match and php data can now be aggregated for a season with group_stats(). I'll probably work on some more wrappers for this function and/or figure out how to aggregate over seasons.

@widbuntu
Copy link
Author

widbuntu commented Jan 5, 2025

I'm not. I haven't worked on it for a few years and have started pursuing some other things - by all means seems like a good name ;) I think you should use it. Originally I put it together mainly to get the schedule of matches.

Yes the pbp can be messy indeed!

@JeffreyRStevens
Copy link
Owner

Awesome, thanks so much @widbuntu!

@JeffreyRStevens
Copy link
Owner

@widbuntu, FYI--the package has been posted on CRAN: https://cran.r-project.org/package=ncaavolleyballr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants