make mongo client configurable #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I misinterpret the logs or is there some unrelated issue on CI? |
JarnoRFB
requested changes
Dec 9, 2022
Co-authored-by: Rüdiger Busche <rudiger.busche@gmail.com>
JarnoRFB
reviewed
Dec 30, 2022
Codecov ReportBase: 98.98% // Head: 98.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 6 6
Lines 393 393
=======================================
Hits 389 389
Misses 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JarnoRFB
approved these changes
Dec 30, 2022
|
@christian-steinmeyer Sorry for the wait, fixed the travis issue now and merged the PR. |
|
@christian-steinmeyer change was released in v0.0.15 |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I'd like to be able to configure the mongo client that's currently abstracted away by the ExperimentLoader. The easiest approach there would be to just forward a set of keyword arguments. What do you think?