diff --git a/deps/v8/src/builtins/builtins-collections-gen.cc b/deps/v8/src/builtins/builtins-collections-gen.cc index 6fea5c37e8c2f2..e5e6026ce61632 100644 --- a/deps/v8/src/builtins/builtins-collections-gen.cc +++ b/deps/v8/src/builtins/builtins-collections-gen.cc @@ -2782,9 +2782,10 @@ TNode WeakCollectionsBuiltinsAssembler::ShouldShrink( TNode WeakCollectionsBuiltinsAssembler::ValueIndexFromKeyIndex( TNode key_index) { - return IntPtrAdd(key_index, - IntPtrConstant(EphemeronHashTable::ShapeT::kEntryValueIndex - - EphemeronHashTable::kEntryKeyIndex)); + return IntPtrAdd( + key_index, + IntPtrConstant(EphemeronHashTable::TodoShape::kEntryValueIndex - + EphemeronHashTable::kEntryKeyIndex)); } TF_BUILTIN(WeakMapConstructor, WeakCollectionsBuiltinsAssembler) { diff --git a/deps/v8/src/codegen/code-stub-assembler.cc b/deps/v8/src/codegen/code-stub-assembler.cc index ec9f176f342d64..170cf773d71c39 100644 --- a/deps/v8/src/codegen/code-stub-assembler.cc +++ b/deps/v8/src/codegen/code-stub-assembler.cc @@ -9455,7 +9455,7 @@ void CodeStubAssembler::NameDictionaryLookup( CAST(UnsafeLoadFixedArrayElement(dictionary, index)); GotoIf(TaggedEqual(current, undefined), if_not_found); if (mode == kFindExisting) { - if (Dictionary::ShapeT::kMatchNeedsHoleCheck) { + if (Dictionary::TodoShape::kMatchNeedsHoleCheck) { GotoIf(TaggedEqual(current, TheHoleConstant()), &next_probe); } current = LoadName(current); diff --git a/deps/v8/src/compiler/turboshaft/assembler.h b/deps/v8/src/compiler/turboshaft/assembler.h index 96303f68300024..81a952bf580145 100644 --- a/deps/v8/src/compiler/turboshaft/assembler.h +++ b/deps/v8/src/compiler/turboshaft/assembler.h @@ -3934,9 +3934,8 @@ class TSAssembler : public Assembler> { public: - explicit TSAssembler(Graph& input_graph, Graph& output_graph, - Zone* phase_zone) - : Assembler(input_graph, output_graph, phase_zone) {} + using Assembler>::Assembler; }; #include "src/compiler/turboshaft/undef-assembler-macros.inc" diff --git a/deps/v8/src/compiler/turboshaft/code-elimination-and-simplification-phase.cc b/deps/v8/src/compiler/turboshaft/code-elimination-and-simplification-phase.cc index 8871e72747fc0b..416d0da2ad3846 100644 --- a/deps/v8/src/compiler/turboshaft/code-elimination-and-simplification-phase.cc +++ b/deps/v8/src/compiler/turboshaft/code-elimination-and-simplification-phase.cc @@ -32,8 +32,7 @@ void CodeEliminationAndSimplificationPhase::Run(Zone* temp_zone) { // (which, for simplificy, doesn't use the Assembler helper // methods, but only calls Next::ReduceLoad/Store). DuplicationOptimizationReducer, - ValueNumberingReducer, - VariableReducerHotfix>::Run(temp_zone); + ValueNumberingReducer>::Run(temp_zone); } } // namespace v8::internal::compiler::turboshaft diff --git a/deps/v8/src/compiler/turboshaft/copying-phase.h b/deps/v8/src/compiler/turboshaft/copying-phase.h index 82c0e506935cb3..64893f7173cbf6 100644 --- a/deps/v8/src/compiler/turboshaft/copying-phase.h +++ b/deps/v8/src/compiler/turboshaft/copying-phase.h @@ -36,16 +36,6 @@ struct PaddingSpace { V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os, PaddingSpace padding); -template -class VariableReducerHotfix : public Next { -public: - void SetVariable(Variable var, OpIndex new_index) {} - Variable NewLoopInvariantVariable(MaybeRegisterRepresentation rep) { return Variable(); } - - OpIndex GetVariable(Variable var) { return OpIndex(); } - OpIndex GetPredecessorValue(Variable var, int predecessor_index) { return OpIndex(); } -}; - template class ReducerBaseForwarder; template @@ -56,9 +46,6 @@ class GraphVisitor : public Next { template friend class ReducerBaseForwarder; - private: - bool contains_variable_reducer_; - public: TURBOSHAFT_REDUCER_BOILERPLATE() @@ -79,8 +66,7 @@ class GraphVisitor : public Next { // `trace_reduction` is a template parameter to avoid paying for tracing at // runtime. template - void VisitGraph(bool contains_variable_reducer) { - contains_variable_reducer_ = contains_variable_reducer; + void VisitGraph() { Asm().Analyze(); // Creating initial old-to-new Block mapping. @@ -191,7 +177,8 @@ class GraphVisitor : public Next { DCHECK(old_index.valid()); OpIndex result = op_mapping_[old_index]; - if (contains_variable_reducer_) { + if constexpr (reducer_list_contains::value) { if (!result.valid()) { // {op_mapping} doesn't have a mapping for {old_index}. The assembler // should provide the mapping. @@ -1307,7 +1294,8 @@ class GraphVisitor : public Next { DCHECK(Asm().input_graph().BelongsToThisGraph(old_index)); DCHECK_IMPLIES(new_index.valid(), Asm().output_graph().BelongsToThisGraph(new_index)); - if (contains_variable_reducer_) { + if constexpr (reducer_list_contains::value) { if (current_block_needs_variables_) { MaybeVariable var = GetVariableFor(old_index); if (!var.has_value()) { @@ -1404,19 +1392,18 @@ class TSAssembler; template