-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot run didScroll correctly. why use backgroundImageView? #152
Comments
IIRC this was a workaround for a bug at the time that it didn't take the correct snapshot and this was a way to pass in the correct view for it to snapshot. This functionality can probably be removed |
@JanGorman |
@JanGorman |
It was only a quick 15 mins of cleanup when I got home yesterday. If you have time to check this further please feel free to do so |
I'm on it. My earlier statement was about something else, I got the two mixed up. So… reason to have the background image view was back then (I wrote the first version 5 years ago 😅) blurring was a bit of a performance concern but indeed these days not an issue. I'll push something shortly |
I noticed that in the example for multiple images:
agrume.didScroll = { [unowned self] index in self.collectionView.scrollToItem(at: IndexPath(item: index, section: 0), at: [], animated: false) }
does not work because the UIViewController behind Agrume is not really shown.
When using blur a backgroundImageView is taking some snapshot which is between UIViewController and Agrume.
What's the usage of backgroundImageView?
after it is dismissed for some reason the didScroll function is being called with some delay in the change.
The text was updated successfully, but these errors were encountered: