Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if source folder exists and exit with helpful error message #310

Closed
egil opened this issue May 24, 2020 · 4 comments · Fixed by #463
Closed

Check if source folder exists and exit with helpful error message #310

egil opened this issue May 24, 2020 · 4 comments · Fixed by #463
Labels
feature request ✨ New feature or request hacktoberfest 🎃 Hacktoberfest related changes. help wanted ❕ Extra attention is needed version 3 Issues related to version 3 of this action.
Milestone

Comments

@egil
Copy link

egil commented May 24, 2020

Describe the solution you'd like
Inspired by #308, where a previous step in a workflow didn't error out, even if the source folder was not create, a less helpful error message was returned by rsync.

The action could help by checking if the source folder exists before calling rsync, and provide a helpful error message instead, if it doesn't.

@JamesIves JamesIves added planned 🕘 This feature is planned. version 3 Issues related to version 3 of this action. labels May 24, 2020
@JamesIves
Copy link
Owner

@JamesIves
Copy link
Owner

JamesIves commented Jun 6, 2020

Sadly this was causing some issues so I've had to roll these changes back until we can investigate further. For some reason the fs.existsSync command was causing the action to exit early right after it creates a new branch. Probably due to an error that ended up throwing and catching silently.

This is the commit with the code changes that were rolled back: 5e3a037

I'm guessing the existsSync command is being executed incorrectly.

@JamesIves JamesIves added help wanted ❕ Extra attention is needed and removed planned 🕘 This feature is planned. labels Jun 6, 2020
@JamesIves JamesIves reopened this Jun 6, 2020
@JamesIves JamesIves added the feature request ✨ New feature or request label Aug 1, 2020
@JamesIves JamesIves added the hacktoberfest 🎃 Hacktoberfest related changes. label Sep 12, 2020
@JamesIves
Copy link
Owner

If anyone would like to pick this up for Hacktoberfest please take a look at my previous comment! I didn't have time to investigate why this is happening but it would be a great thing to add!

@JamesIves
Copy link
Owner

This has been added as part of version 3.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ✨ New feature or request hacktoberfest 🎃 Hacktoberfest related changes. help wanted ❕ Extra attention is needed version 3 Issues related to version 3 of this action.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants