-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test launcher mac menu #9266
Test launcher mac menu #9266
Conversation
MWE code for a JavaFX application https://github.com/dlemmermann/JPackageScriptFX/blob/master/jpackagefx-main/src/main/java/com/dlsc/jpackagefx/App.java - seems to be similar to the current one. In yesterday's call we guessed, it could be a timing issue. |
Fuu. Now it doesn't event start when I download the build version |
Can you please set a breakpoint in https://github.com/openjdk/jfx/blob/b3eec1d655ca8d17d13615ea430e92058d99ec1c/modules/javafx.graphics/src/main/java/com/sun/javafx/application/LauncherImpl.java#L675, and report the differences between the current vs old startup. Thanks! |
This seems to work now. I will check again with the master then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
@@ -45,8 +45,10 @@ | |||
*/ | |||
public class Launcher { | |||
private static Logger LOGGER; | |||
private static String[] ARGUMENTS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this field really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure the original args are no modified
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)