From 266b3acd3150d5f015c3d0afe09c92a1a33ee805 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Thu, 2 Jan 2020 00:49:09 +0100 Subject: [PATCH 1/3] Disable ACM Fetcher --- src/main/java/org/jabref/logic/importer/WebFetchers.java | 4 ++-- .../jabref/logic/importer/fetcher/ACMPortalFetcherTest.java | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jabref/logic/importer/WebFetchers.java b/src/main/java/org/jabref/logic/importer/WebFetchers.java index 66319f5e6b4..45f035914ca 100644 --- a/src/main/java/org/jabref/logic/importer/WebFetchers.java +++ b/src/main/java/org/jabref/logic/importer/WebFetchers.java @@ -7,7 +7,6 @@ import java.util.SortedSet; import java.util.TreeSet; -import org.jabref.logic.importer.fetcher.ACMPortalFetcher; import org.jabref.logic.importer.fetcher.ACS; import org.jabref.logic.importer.fetcher.ArXiv; import org.jabref.logic.importer.fetcher.AstrophysicsDataSystem; @@ -90,7 +89,8 @@ public static SortedSet getSearchBasedFetchers(ImportFormatP set.add(new AstrophysicsDataSystem(importFormatPreferences)); set.add(new MathSciNet(importFormatPreferences)); set.add(new ZbMATH(importFormatPreferences)); - set.add(new ACMPortalFetcher(importFormatPreferences)); + // see https://github.com/JabRef/jabref/issues/5804 + // set.add(new ACMPortalFetcher(importFormatPreferences)); set.add(new GoogleScholar(importFormatPreferences)); set.add(new DBLPFetcher(importFormatPreferences)); set.add(new SpringerFetcher()); diff --git a/src/test/java/org/jabref/logic/importer/fetcher/ACMPortalFetcherTest.java b/src/test/java/org/jabref/logic/importer/fetcher/ACMPortalFetcherTest.java index 4a673179f57..25e1c6dbd30 100644 --- a/src/test/java/org/jabref/logic/importer/fetcher/ACMPortalFetcherTest.java +++ b/src/test/java/org/jabref/logic/importer/fetcher/ACMPortalFetcherTest.java @@ -12,6 +12,7 @@ import org.jabref.testutils.category.FetcherTest; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -19,6 +20,7 @@ import static org.mockito.Mockito.when; @FetcherTest +@Disabled("ACM endpoint does not work, thus the fetcher does not work at all. See https://github.com/JabRef/jabref/issues/5804 for details.") class ACMPortalFetcherTest { ACMPortalFetcher fetcher; From ed0e5aecdffc29d4368d9c777f0ba903bbb282a0 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Thu, 2 Jan 2020 01:04:53 +0100 Subject: [PATCH 2/3] Adapt WebFetchersTest --- .../java/org/jabref/logic/importer/WebFetchersTest.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/test/java/org/jabref/logic/importer/WebFetchersTest.java b/src/test/java/org/jabref/logic/importer/WebFetchersTest.java index 9ce8e083c35..3796dc16334 100644 --- a/src/test/java/org/jabref/logic/importer/WebFetchersTest.java +++ b/src/test/java/org/jabref/logic/importer/WebFetchersTest.java @@ -4,6 +4,7 @@ import java.util.Set; import java.util.stream.Collectors; +import org.jabref.logic.importer.fetcher.ACMPortalFetcher; import org.jabref.logic.importer.fetcher.AbstractIsbnFetcher; import org.jabref.logic.importer.fetcher.IsbnViaEbookDeFetcher; import org.jabref.logic.importer.fetcher.IsbnViaOttoBibFetcher; @@ -39,9 +40,14 @@ void getIdBasedFetchersReturnsAllFetcherDerivingFromIdBasedFetcher() throws Exce expected.remove(AbstractIsbnFetcher.class); expected.remove(IdBasedParserFetcher.class); + // Remove special ISBN fetcher since we don't want to expose them to the user expected.remove(IsbnViaEbookDeFetcher.class); expected.remove(IsbnViaOttoBibFetcher.class); + + // Remove ACM, because it doesn't work currently + expected.remove(ACMPortalFetcher.class); + assertEquals(expected, getClasses(idFetchers)); } } From 60dd9d53f6dfa101fadf10dffb17f20cbba5e8f2 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Thu, 2 Jan 2020 01:15:03 +0100 Subject: [PATCH 3/3] Remove ACM Fetcher in one more check --- src/test/java/org/jabref/logic/importer/WebFetchersTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/test/java/org/jabref/logic/importer/WebFetchersTest.java b/src/test/java/org/jabref/logic/importer/WebFetchersTest.java index 3796dc16334..904f8198716 100644 --- a/src/test/java/org/jabref/logic/importer/WebFetchersTest.java +++ b/src/test/java/org/jabref/logic/importer/WebFetchersTest.java @@ -74,6 +74,10 @@ void getSearchBasedFetchersReturnsAllFetcherDerivingFromSearchBasedFetcher() thr Set> expected = controlClasses.loadClasses().stream().collect(Collectors.toSet()); expected.remove(SearchBasedParserFetcher.class); + + // Remove ACM, because it doesn't work currently + expected.remove(ACMPortalFetcher.class); + assertEquals(expected, getClasses(searchBasedFetchers)); } }