Added integrity checker for odd number of # #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +11,11 @@ | |||
| import net.sf.jabref.model.entry.ParsedFileField; | |||
|
|
|||
| import java.io.File; | |||
| import java.util.*; | |||
There was a problem hiding this comment.
I think the sorting of the imports differs from #1091
There was a problem hiding this comment.
I use Eclipse, so it should behave as we want it to if nothing else... I changed it manually though.
There was a problem hiding this comment.
OK! I didn't follow it that much, but got the impression that those were the correct settings (I use another version btw, so slightly different look).
|
LGTM 👍 |
|
Hm, yes, would make sense @tobiasdiez . I would merge this in with the current structure but for the next checker we should create separate classes. |
|
Go ahead an merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will sometimes help for #1212 and #1188