Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences are not stored #6770

Closed
1 task done
mwip opened this issue Aug 19, 2020 · 7 comments
Closed
1 task done

Preferences are not stored #6770

mwip opened this issue Aug 19, 2020 · 7 comments

Comments

@mwip
Copy link

mwip commented Aug 19, 2020

JabRef version 5.0 / 5.1--2020-08-19--9adfd5b on Ubuntu 20.04

Linux 5.4.0-42-generic amd64
Java 14.0.2

Preferences that I make in the Options -> Preferences are not stored at all. Namely, I want to change the default Key pattern to [auth:lower][year][veryshorttitle:lower]. When I click save and open the Preferences again immediately, I see the default key pattern again.

I installed both the stable release as well as the development version using dpkg -i. Might this have to do with the way I installed it and hence messed up permissions on any config files? I also don't get an event log.

Steps to reproduce the behavior:

  1. Open Options, Preferences
  2. Go to Citation Key Generator
  3. Double click the Default pattern "Key Pattern"
  4. Enter desired pattern
  5. Click Save
  6. Open Options, Preferences
  7. Check Key Pattern -> it has not been saved.
@Siedlerchr
Copy link
Member

Did you press enter after entering the new pattern? That is a common problem.

@mwip
Copy link
Author

mwip commented Aug 19, 2020

That indeed solves the problem -- thanks.

That said, I think behaviour this is very counter intuitive. Even if it is as intended, one should be alterted that some settings will not be stored.

@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 19, 2020

We are aware of this and fully agree with you. Unfortunately it's the default behavior of the underlying javafx gui framework which we cannot change. However, we have a warning in the help page for the dialog.
@calixtus already looked into this. Didn't you implement sth for the string dialog?

@calixtus
Copy link
Member

No I did not. In fact, it's a well known bug in JavaFX. There are possible workarounds, some work better, some not, they all come with sideeffects (e.g. https://gist.github.com/james-d/be5bbd6255a4640a5357). We do have this on our priority list, but this would take some more work.
see https://bugs.openjdk.java.net/browse/JDK-8089514
and here https://github.com/kleopatra/swingempire-fx/tree/master9/fx8-swingempire/src/tableedit/de/swingempire/fx/scene/control/edit

@calixtus
Copy link
Member

Maybe we need to place a hint on the tables to press return to commit changes as a temporary solution, as long as the bug persists? @Siedlerchr @koppor @tobiasdiez

@calixtus
Copy link
Member

refs #6432 #5825

@Siedlerchr
Copy link
Member

I'll close that now. Added the idea from calixtus to the linked issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants