Set better default windows size for maintable beta version

[psychelzh]

It is quite ugly when you first startup the maintable beta version of JabRef:

Plus, it won't memorize my modifications, either. That is, after I modify the size to a better one, it restores to the default again when I restart it.

This is better:

JabRef 4.2-dev--snapshot--2018-03-16--maintable-beta--2c2a302a5
Windows 10 10.0 amd64 
Java 1.8.0_161

[JavierMF]

I felt this annoying too. Just adding mainStage.setMaximized(true); on starting would provide a wider visualization. Is that ok?

[tobiasdiez]

I agree that the window should be maximized by default. We also have preference values that sound related but are apparently ignored on start. I think, their original purpose was to save the window location across sessions. It would be nice if this could be investigated as part of resolving the issue at hand.

jabref/src/main/java/org/jabref/preferences/JabRefPreferences.java

Lines 500 to 505 in cc3f7f0

	defaults.put(POS_X, 0);
	defaults.put(POS_Y, 0);
	defaults.put(SIZE_X, 1024);
	defaults.put(SIZE_Y, 768);
	defaults.put(WINDOW_MAXIMISED, Boolean.FALSE);
	defaults.put(AUTO_RESIZE_MODE, Boolean.TRUE);

[JavierMF]

WINDOW_MAXIMISED is used for reading on start:

jabref/src/main/java/org/jabref/JabRefGUI.java

Lines 156 to 158 in 66afd42

	if (Globals.prefs.getBoolean(JabRefPreferences.WINDOW_MAXIMISED)) {
	mainStage.setMaximized(true);
	}

but never updated.

POS_X, POS_X, SIZE_X and SIZE_Y are never used.

AUTO_RESIZE_MODE seems related to the MainTable, not to the Window.

jabref/src/main/java/org/jabref/preferences/JabRefPreferences.java

Lines 1878 to 1882 in 66afd42

	public MainTablePreferences getMainTablePreferences() {
	return new MainTablePreferences(
	getColumnPreferences(),
	getBoolean(AUTO_RESIZE_MODE));
	}

My proposal would be:

• set the WINDOW_MAXIMISED default to true
• save the window state (maximinization state, pos and size) when closing the application
• reload the window state on start if different to defaults

What do you think?

[tobiasdiez]

Thanks for the investigation. Sounds like a good solution to me!

[ukleine]

JabRef 5.0-dev--snapshot--2018-11-09--master--bab9ae819
Linux 4.12.14-lp150.12.25-default amd64, KDE Plasma 5.12.6
Java 1.8.0_171

The above version does not save the X window size on exit. If for testing I change the window size with Version 4.3.1, the development version does open with with that window size. So it is only an issue with properly saving the window size.

[Siedlerchr]

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.