Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citation relations should be able to handle strange DOIs. #10985

Closed
koppor opened this issue Mar 4, 2024 · 2 comments · Fixed by #10989
Closed

Citation relations should be able to handle strange DOIs. #10985

koppor opened this issue Mar 4, 2024 · 2 comments · Fixed by #10989
Assignees
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Mar 4, 2024

I queried dblp for "Breitenbücher".

Following entry came out:

@InProceedings{Hahn2018b,
  author    = {Michael Hahn and Uwe Breitenb{\"{u}}cher and Frank Leymann and Vladimir Yussupov},
  booktitle = {On the Move to Meaningful Internet Systems. {OTM} 2018 Conferences - Confederated International Conferences: CoopIS, C{\&}TC, and {ODBASE} 2018, Valletta, Malta, October 22-26, 2018, Proceedings, Part {II}},
  date      = {2018},
  title     = {Transparent Execution of Data Transformations in Data-Aware Service Choreographies},
  doi       = {10.1007/978-3-030-02671-4\_7},
  editor    = {Herv{\'{e}} Panetto and Christophe Debruyne and Henderik A. Proper and Claudio Agostino Ardagna and Dumitru Roman and Robert Meersman},
  pages     = {117--137},
  publisher = {Springer},
  series    = {Lecture Notes in Computer Science},
  url       = {https://doi.org/10.1007/978-3-030-02671-4_7},
  volume    = {11230},
  bibsource = {dblp computer science bibliography, https://dblp.org},
  biburl    = {https://dblp.org/rec/conf/otm/0002BLY18.bib},
  owner     = {koppor11},
}

Thus, I have the DOI 10.1007/978-3-030-02671-4\_7

When activating "Citation Relations", I get

Illegal character in path at index 76: https://api.semanticscholar.org/graph/v1/paper/DOI:10.1007/978-3-030-02671-4\_7/references?fields=title,authors,year,citationCount,referenceCount&limit=1000
Error while fetching citing Articles
java.lang.IllegalArgumentException: Illegal character in path at index 76: https://api.semanticscholar.org/graph/v1/paper/DOI:10.1007/978-3-030-02671-4\_7/citations?fields=title,authors,year,citationCount,referenceCount&limit=1000

I think, this needs to be fixed at the DOI parsing logic (or at semantic scholar?)


This issue is more about code reading and code understanding. The fix itself is probably 3 lines of code and 10 lines of test case.

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 4, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Mar 4, 2024
@AbdAlRahmanGad
Copy link
Contributor

Can I work on this issue?

@koppor
Copy link
Member Author

koppor commented Mar 5, 2024

@AbdAlRahmanGad Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants