Fix cancelling ignored when generating an entry from id

JabRef · Dec 26, 2023 · d0edf3a · d0edf3a
1 parent b711863
commit d0edf3a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/main/java/org/jabref/gui/EntryTypeView.java b/src/main/java/org/jabref/gui/EntryTypeView.java
@@ -81,6 +81,7 @@ public EntryTypeView(LibraryTab libraryTab, DialogService dialogService, Prefere
                   .setAsDialogPane(this);
 
         ControlHelper.setAction(generateButton, this.getDialogPane(), event -> viewModel.runFetcherWorker());
+        setOnCloseRequest(e -> viewModel.cancelFetcherWorker());
 
         setResultConverter(button -> {
             // The buttonType will always be "cancel", even if we pressed one of the entry type buttons

diff --git a/src/main/java/org/jabref/gui/EntryTypeViewModel.java b/src/main/java/org/jabref/gui/EntryTypeViewModel.java
@@ -211,4 +211,8 @@ public void runFetcherWorker() {
         });
         taskExecutor.execute(fetcherWorker);
     }
+
+    public void cancelFetcherWorker() {
+        fetcherWorker.cancel();
+    }
 }