Skip to content

Commit

Permalink
Added default Icon to all JavaFX dialogs that inherit from FXAlert (#…
Browse files Browse the repository at this point in the history
…1940)

* Added default icon to all fx dialogs created via FXAlert

* Using normal localization files to get key binding category names
  • Loading branch information
boceckts authored and tobiasdiez committed Sep 11, 2016
1 parent 37a3486 commit 4196077
Show file tree
Hide file tree
Showing 19 changed files with 82 additions and 35 deletions.
4 changes: 4 additions & 0 deletions src/main/java/net/sf/jabref/gui/FXAlert.java
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ public FXAlert(AlertType type, String title) {

public FXAlert(AlertType type) {
super(type);

Image image = new Image(IconTheme.getIconUrl("jabrefIcon48").toString());
setDialogIcon(image);

Stage fxDialogWindow = getDialogWindow();

fxDialogWindow.setOnShown(evt -> {
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/net/sf/jabref/gui/keyboard/KeyBindingCategory.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
public enum KeyBindingCategory {

FILE(
Localization.menuTitle("File")),
Localization.lang("File")),
EDIT(
Localization.menuTitle("Edit")),
Localization.lang("Edit")),
SEARCH(
Localization.menuTitle("Search")),
Localization.lang("Search")),
VIEW(
Localization.menuTitle("View")),
Localization.lang("View")),
BIBTEX(
Localization.BIBTEX),
QUALITY(
Localization.menuTitle("Quality")),
Localization.lang("Quality")),
TOOLS(
Localization.menuTitle("Tools"));
Localization.lang("Tools"));

private final String name;

Expand Down
11 changes: 2 additions & 9 deletions src/main/resources/l10n/JabRef_da.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1072,11 +1072,6 @@ One_entry_needed_a_clean_up=
Error_downloading_file_'%0'=Feil_ved_hentning_af_filen_'%0'
Download_failed=Hentning_mislykkedes
%0_databases_will_be_imported=%0_databaser_vil_blive_importeret
Importing_canceled=Import_afbrudt
There_are_no_available_databases_to_be_imported=Det_er_ingen_databaser_tilgængelige_for_import
Import_from_SQL_database=Import_fra_SQL-database
Imported_%0_databases_successfully=Importerede_%0_databaser
<_CREATE_NEW_DATABASE_>=<_OPRET_NY_DATABASE_>
Remove_selected=Fjern_valgte

Group_tree_could_not_be_parsed._If_you_save_the_BibTeX_database,_all_groups_will_be_lost.=
Expand Down Expand Up @@ -1301,10 +1296,6 @@ Could_not_connect_to_%0=Kunne_ikke_forbinde_til_%0
Accepting_the_change_replaces_the_complete_groups_tree_with_the_externally_modified_groups_tree.=
Added_entry=
Added_new_'%0'_entry.=
Choose_the_URL_to_download.=
Could_not_connect_to_SQL_database_for_the_following_reason\:=
Could_not_export_to_SQL_database_for_the_following_reason\:=
Could_not_import_from_SQL_database_for_the_following_reason\:=
Deleted_entry=
Discard_changes=
Donate_to_JabRef=
Expand Down Expand Up @@ -1800,3 +1791,5 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Tools=
8 changes: 4 additions & 4 deletions src/main/resources/l10n/JabRef_de.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1999,10 +1999,6 @@ Could_not_connect_to_%0=Verbindung_zu_%0_fehlgeschlagen
Accepting_the_change_replaces_the_complete_groups_tree_with_the_externally_modified_groups_tree.=Akzeptieren_der_Änderungen_führt_dazu,_dass_die_komplette_Gruppenstruktur_durch_die_externen_Änderungen_erstetzt_wird.
Added_entry=Eintrag_hinzugefügt
Added_new_'%0'_entry.=Neuer_'%0'_Eintrag_hinzugefügt.
Choose_the_URL_to_download.=Wählen_Sie_die_Download-URL
Could_not_connect_to_SQL_database_for_the_following_reason\:=Verbindung_zur_SQL-Datenbak_aus_folgendem_Grund_fehlgeschlagen\:
Could_not_export_to_SQL_database_for_the_following_reason\:=Export_in_die_SQL-Datenbak_aus_folgendem_Grund_fehlgeschlagen\:
Could_not_import_from_SQL_database_for_the_following_reason\:=Import_aus_der_SQL-Datenbak_aus_folgendem_Grund_fehlgeschlagen\:
Deleted_entry=Eintrag_gelöscht
Discard_changes=Änderungen_verwerfen

Expand Down Expand Up @@ -2565,3 +2561,7 @@ shared=geteilt

should_contain_an_integer_or_a_literal=
should_have_the_first_letter_capitalized=

Download=
Download_completed=
Tools=
1 change: 1 addition & 0 deletions src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2309,3 +2309,4 @@ last_four_nonpunctuation_characters_should_be_numerals=last_four_nonpunctuation_
shared=shared
should_contain_an_integer_or_a_literal=should_contain_an_integer_or_a_literal
should_have_the_first_letter_capitalized=should_have_the_first_letter_capitalized
Tools=Tools
8 changes: 2 additions & 6 deletions src/main/resources/l10n/JabRef_es.properties
Original file line number Diff line number Diff line change
Expand Up @@ -984,13 +984,7 @@ One_entry_needed_a_clean_up=Sólo_una_entrada_necesitó_limpieza
%0_entries_needed_a_clean_up=%0_entradas_necesitarion_limpieza
Error_downloading_file_'%0'=Error_descargando_el_archivo_'%0'
Download_failed=Falló_la_descarga
Error_importing_from_database=Error_al_importar_desde_base_de_datos
%0_databases_will_be_imported=%0_bases_de_datos_serán_importadas
Importing_canceled=Importación_cancelada
There_are_no_available_databases_to_be_imported=No_hay_bases_de_datos_disaponibles_para_importar
Import_from_SQL_database=Importar_desde_base_de_datos_SQL
Imported_%0_databases_successfully=%0_bases_de_datos_importadas_con_éxito
<_CREATE_NEW_DATABASE_>=<_CREAR_NUEVA_BASE_DE_DATOS_>
Remove_selected=Eliminar_seleccionados
Group_tree_could_not_be_parsed._If_you_save_the_BibTeX_database,_all_groups_will_be_lost.=El_arbol_de_grupo_no_puede_ser_examinado._Si_guarda_la_base_de_datos_BibTeX,_todos_los_grupos_se_perderán.
Attach_file=Adjuntar_archivo
Expand Down Expand Up @@ -1698,3 +1692,5 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Tools=
4 changes: 4 additions & 0 deletions src/main/resources/l10n/JabRef_fa.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2470,3 +2470,7 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Download=
Download_completed=
Tools=
6 changes: 5 additions & 1 deletion src/main/resources/l10n/JabRef_fr.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1736,4 +1736,8 @@ Remember_password?=
shared=
should_contain_an_integer_or_a_literal=
should_have_the_first_letter_capitalized=
should_have_the_first_letter_capitalized=
Error_downloading_file_'%0'=
Download_failed=
%0_databases_will_be_imported=
Tools=
5 changes: 5 additions & 0 deletions src/main/resources/l10n/JabRef_in.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1705,3 +1705,8 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Error_downloading_file_'%0'=
Download_failed=
%0_databases_will_be_imported=
Tools=
5 changes: 5 additions & 0 deletions src/main/resources/l10n/JabRef_it.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1807,3 +1807,8 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Error_downloading_file_'%0'=
Download_failed=
%0_databases_will_be_imported=
Tools=
10 changes: 5 additions & 5 deletions src/main/resources/l10n/JabRef_ja.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1752,7 +1752,6 @@ One_entry_needed_a_clean_up=1つの項目を消去する必要がありました
%0_entries_needed_a_clean_up=%0個の項目を消去する必要がありました
Error_downloading_file_'%0'=ファイル「%0」をダウンロードする際にエラー発生
Download_failed=ダウンロードに失敗しました
Error_importing_from_database=データベースの読み込み時にエラー発生

Remove_selected=選択分を削除

Expand Down Expand Up @@ -1980,10 +1979,6 @@ Could_not_connect_to_%0=%0に接続することができませんでした
Accepting_the_change_replaces_the_complete_groups_tree_with_the_externally_modified_groups_tree.=変更を承認すると、外部で修正されたグループツリーで,グループツリー全体を置き換えます。
Added_entry=項目を追加しました
Added_new_'%0'_entry.=「%0」項目を新規に追加しました。
Choose_the_URL_to_download.=ダウンロードするURLを選んでください。
Could_not_connect_to_SQL_database_for_the_following_reason\:=下記の理由により、SQLデータベースに接続できませんでした;
Could_not_export_to_SQL_database_for_the_following_reason\:=下記の理由により、SQLデータベースに書き出せませんでした;
Could_not_import_from_SQL_database_for_the_following_reason\:=下記の理由により、SQLデータベースから読み込めませんでした;
Deleted_entry=項目を削除
Discard_changes=変更を放棄
Donate_to_JabRef=JabRefに寄付する
Expand Down Expand Up @@ -2457,3 +2452,8 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Download=
Download_completed=
%0_databases_will_be_imported=
Tools=
7 changes: 7 additions & 0 deletions src/main/resources/l10n/JabRef_nl.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2476,3 +2476,10 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Download=
Download_completed=
Error_downloading_file_'%0'=
Download_failed=
%0_databases_will_be_imported=
Tools=
7 changes: 7 additions & 0 deletions src/main/resources/l10n/JabRef_no.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2869,3 +2869,10 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Download=
Download_completed=
Error_downloading_file_'%0'=
Download_failed=
%0_databases_will_be_imported=
Tools=
4 changes: 3 additions & 1 deletion src/main/resources/l10n/JabRef_pt_BR.properties
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,6 @@ One_entry_needed_a_clean_up=Uma_referência_necessitou_limpeza
%0_entries_needed_a_clean_up=%0_entradas_necessitaram_limpeza
Error_downloading_file_'%0'=Erro_ao_baixar_arquivo_'%0'
Download_failed=O_download_falhou
Error_importing_from_database=Erro_ao_importar_do_banco_de_dados

Remove_selected=Remover_Selecionados
Group_tree_could_not_be_parsed._If_you_save_the_BibTeX_database,_all_groups_will_be_lost.=Árvore_de_agrupamento_não_pode_ser_interpretada._Se_você_salvar_sua_base_de_dados_BibTeX,_todos_os_grupos_serão_perdidos
Expand Down Expand Up @@ -1706,3 +1705,6 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

%0_databases_will_be_imported=
Tools=
4 changes: 4 additions & 0 deletions src/main/resources/l10n/JabRef_ru.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2448,3 +2448,7 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Download=
Download_completed=
Tools=
6 changes: 4 additions & 2 deletions src/main/resources/l10n/JabRef_sv.properties
Original file line number Diff line number Diff line change
Expand Up @@ -502,8 +502,6 @@ Generate_keys_for_imported_entries=Generera_nycklar_för_importerade_poster
Generate_now=Generera_nu
Generated_BibTeX_key_for=Genererade_BibTeX-nycklar_för
Generating_BibTeX_key_for=Genererar_BibTeX-nycklar_för
Grab=
Get_BibTeX_entry_from_DiVA=Hämta_BibTeX-post_från_DIVA
Gray_out_entries_not_in_group_selection=Skugga_poster_som_inte_är_med_i_en_grupp
Gray_out_non-hits=Skugga_icke-träffar
Group_tree_could_not_be_parsed._If_you_save_the_BibTeX_database,_all_groups_will_be_lost.=Gruppträdet_kunde_inte_läsas_in._Om_du_sparar_din_databas_kommer_alla_grupper_att_förloras.
Expand Down Expand Up @@ -1658,3 +1656,7 @@ shared=delad

should_contain_an_integer_or_a_literal=
should_have_the_first_letter_capitalized=

Error_downloading_file_'%0'=
%0_databases_will_be_imported=
Tools=
3 changes: 2 additions & 1 deletion src/main/resources/l10n/JabRef_tr.properties
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ Invalid_BibTeX_key=Geçersiz_BibTeX_anahtarı
Invalid_date_format=Geçersiz_tarih_biçemi
Invalid_URL=Geçersiz_URL
Inverted=Ters_çevrilmiş
ISO_abbreviation=ISO_kısaltması
Online_help=Çevrimiçi_yardım
Online_help=
JabRef_preferences=JabRef_tercihler
Expand Down Expand Up @@ -1732,3 +1731,5 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Tools=
7 changes: 7 additions & 0 deletions src/main/resources/l10n/JabRef_vi.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2471,3 +2471,10 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Download=
Download_completed=
Error_downloading_file_'%0'=
Download_failed=
%0_databases_will_be_imported=
Tools=
5 changes: 5 additions & 0 deletions src/main/resources/l10n/JabRef_zh.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1714,3 +1714,8 @@ should_have_the_first_letter_capitalized=
Remember_password?=

shared=

Error_downloading_file_'%0'=
Download_failed=
%0_databases_will_be_imported=
Tools=

0 comments on commit 4196077

Please sign in to comment.