-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hdf5 and fms versions for spack-stack/1.4.0 #587
Conversation
Revert to EMC spack-stack dev
We'll need a PR for spack that adds those versions, in case they don't exist yet. Also, please bump |
I am also in favor of updating to esmf@8.4.2 and mapl@2.35.2, this will solve a whole lot of problems on Narwhal, Gaea, macOS, ... |
… submodule pointer.
done (JCSDA/spack#268) & done. |
i updated the default esmf/mapl versions in common/packages.yaml. |
CI tests passed, I am going to merge the spack PR (and then this PR needs to be updated). |
I updated the submodule pointer following the merge of JCSDA/spack#268, and reverted |
I also added the missing mapl-esmf modulefile suffices in configs/common/modules.yaml. CI tests are running again. |
@AlexanderRichert-NOAA This is ready to merge once approved from your side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating. I tested on my M1 Mac and spack-stack built properly, as well as jedi-bundle and I saw the usual (epxected) jedi-bundle ctest failures.
thanks for testing steve!! |
Thanks very much for taking the time to test this, and for the quick turnaround! |
Description
Updates
hdf5
,fms
,esmf
, andmapl
versions (to 1.14.1, 2023.01, 8.4.2, and 2.35.2, respectively) in anticipation of forthcoming ufs-wm changes (see #586, UFS-WM #1745). These versions should be used in thespack-stack/1.4.0
release.Definition of Done
hdf5
,fms
,esmf
, andmapl
versions are updated in configs/common/packages.yaml.Issue(s) addressed
Fixes #586
Fixes #553
Fixes #524
Dependencies
spack #268
Impact
None known