Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Modify a few ozone conversion issues in GFS diagnostic converter #1296

Open
emilyhcliu opened this issue Jul 15, 2023 · 1 comment
Open
Assignees
Labels
bug Something is not working NWS NOAA National Weather Service

Comments

@emilyhcliu
Copy link
Contributor

emilyhcliu commented Jul 15, 2023

Current behavior (describe the bug)

Two issues:

  1. The current converter for ozone can not convert the user-desired data type to IODA.
  2. The following Ozone quality control variables from BUFR need proper IODA names
  • Total Ozone Quality Code (TOQC) ---- This is related to retrieval quality
  • Total Ozone Quality Flag (TOQF) --- This is related to observation quality
  • Total Ozone Quality (SBOVTOQ) --- This is related to retrieval quality
  • Profile Ozone Quality (SBOVPOQ) --- This is related to retrieval quality
  • Algorithm Flag for Best Ozone (AFBO)

Reference - Code Table

Fixes proposed:

  1. The capability to convert the user-desired data type is added for Ozone data
  2. Proposed variable names:
    • Total Ozone Quality Code (TOQC) ---> totalOzoneQuality
    • Total Ozone Quality Flag (TOQF) ---> totalOzoneQualityFlag
    • Total Ozone Quality (SBUVTOQ)- --> totalOzoneQuality
    • Profile Ozone Quality (SBUVPOQ) ---> profileOzoneQuality
    • Algorithm Flag for Best Ozone ---> bestOzoneAlgorithmFlag

TOQC and SBUVTOQ are related to retrieval quality; therefore, they are assigned to the same IODA name totalOzoneQuality

These fixes do not change the scientific results. These changes are made to follow the IODA convention.

To Reproduce

N/A
...

Expected behavior

The ozone quality related variables should be written to IODA as integer
The name of the ozone quality related variable names would follow IODA naming convention

Additional information (optional)

Related to IODA Issue #1054

@emilyhcliu emilyhcliu added the bug Something is not working label Jul 15, 2023
@emilyhcliu emilyhcliu self-assigned this Jul 15, 2023
@BenjaminRuston
Copy link
Collaborator

@emilyhcliu is this still ongoing

@BenjaminRuston BenjaminRuston added the NWS NOAA National Weather Service label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working NWS NOAA National Weather Service
Projects
None yet
Development

No branches or pull requests

2 participants