Skip to content
This repository has been archived by the owner on Mar 31, 2024. It is now read-only.

Create pypi package #11

Open
rasheed-rd opened this issue Nov 28, 2022 · 5 comments
Open

Create pypi package #11

rasheed-rd opened this issue Nov 28, 2022 · 5 comments

Comments

@rasheed-rd
Copy link

Is your feature request related to a problem? Please describe.
No pypi package exists for XSStrike. The following are a couple of reasons why having a pypi package is useful:

  • Having a src dir allows someone to import the project and use it as another python package.
  • Having it on pypi greatly simplifies the installation of the tool and its dependencies as it allows someone to import it via pip/poetry/any python package manager.

Describe the solution you'd like
Convert XSStrike into a package that can be published to pypi.

@ItsIgnacioPortal if you agree that creating a pypi package for XSStike is useful I can do the work and create a PR for it.

@ItsIgnacioPortal
Copy link
Owner

@ItsIgnacioPortal if you agree that creating a pypi package for XSStike is useful I can do the work and create a PR for it.

Good proposal @rasheed-rd :) Would it use a Github Action? If that's the case, you can make a PR with the yaml file, and I'll handle the account stuff.

@Chandra158
Copy link

Hi @rasheed-rd, this seems useful. Any update on this ?

@rasheed-rd
Copy link
Author

Hi @rasheed-rd, this seems useful. Any update on this ?

Hi, so I had a project that required I get XSStrike packaged and published ASAP. This lead me to fork the original project, package it, and publish to PyPi.

If possible I would like to figure out a way to include the new features added to this fork.

@ItsIgnacioPortal
Copy link
Owner

If possible I would like to figure out a way to include the new features added to this fork.

You could've done the same but instead of forking the original repo, fork this repo :p

Either way, if anyone's interested in making this a package, feel free to make a pull request. I personally don't see much benefit from it; Not that I don't value package managers, it's just that I already have a solution for this problem. It also seems like making this into a package for pypi requires the entire project to be re-structured, so I'm not looking forward to that 😅

@rasheed-rd
Copy link
Author

You could've done the same but instead of forking the original repo, fork this repo :p

You're right I guess I could have :). I think the reason I didn't, was I needed to get something into pypi immediately and I had access to the xsstrike project on pypi. I knew it would require a major restructuring effort which may not have been desirable, so I wanted to keep it separate for the time being.

For me the reason a package is important is that it allows it to be installed easily as a dependency in other python projects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants