Travis and local sniffs out of alignment

[dannylamb]

Noticed this on Islandora/islandora#756

Travis seems to be using a different version of the Drupal sniff than what I've got locally. I'm using ISLE, but it riffs off of the playbook so they may very well be the same version.

We either need to lock everything down or bite the bullet and update to the newest sniff and get into alignment. Might also be worth considering the DrupalPractice sniff now if we really want to step it up.

[ajstanley]

There's another issue of tests that used to pass are failing now.
I can bring 8.x-1.x up to coding standards this weekend.

[rosiel]

I'm proposing to update the documentation (see above PR).

In the version of ISLE i've got (make local), phpcs does not appear to be installed. Are there instructions for doing that, since that's what this particular issue was about?

[kstapelfeldt]

Group felt that we should be using at least Drupal, and ideally Drupal & Drupal Practice. @rosiel can you update your documentation PR to reflect this?

[elizoller]

to start https://github.com/Islandora/islandora_ci/blob/main/travis_scripts.sh#L16 would have to include DrupalPractice as well

[rosiel]

At the moment, it appears that phpcs is failing on the very line @elizoller pointed above.
PR that's failing checks: Islandora/controlled_access_terms#78
errors: https://github.com/Islandora/controlled_access_terms/runs/5058696572?check_suite_focus=true

The error is "ERROR: Referenced sniff "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" does not exist"

Does anyone know why this is happening?