Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 8.7 is released #1110

Closed
Natkeeran opened this issue May 3, 2019 · 9 comments · Fixed by Islandora-Devops/islandora-playbook#118
Closed

Drupal 8.7 is released #1110

Natkeeran opened this issue May 3, 2019 · 9 comments · Fixed by Islandora-Devops/islandora-playbook#118
Milestone

Comments

@Natkeeran
Copy link
Contributor

Drupal 8.7 has been released.

We need to test and update Drupal to 8.7 the drupal project composer.json.

This issue that was throwing exceptions in ansible and that necessitated https://github.com/Islandora-Devops/claw-playbook/blob/master/post-install.yml#L13 has been fixed.

@dannylamb dannylamb added this to the 1.0.0 milestone May 8, 2019
@mjordan
Copy link
Contributor

mjordan commented May 8, 2019

Can we test #1035 as part of this?

@Natkeeran
Copy link
Contributor Author

@dannylamb It seems like there is more to that than simply changing the drupal version. Also, wondering if you want to pull in changes from https://github.com/drupal-composer/drupal-project.

@dannylamb
Copy link
Contributor

@Natkeeran Yes, please. I usually pull in the latest from upstream whenever I'm stomping around in there. What are you running into?

@Natkeeran
Copy link
Contributor Author

@dannylamb
Here is an attempt: https://github.com/Islandora-CLAW/drupal-project/tree/drupal_87

  1. how to test this without being able to update composer package
  2. how does the composer.lock file gets updated?

@Natkeeran
Copy link
Contributor Author

Natkeeran commented May 23, 2019

@mjordan

This issue (https://www.drupal.org/project/drupal/issues/2350939) is not fixed, thus 1035 is not fixed.

The ansible issue is fixed.

@whikloj whikloj modified the milestones: 1.0.0, 1.x May 24, 2019
@dannylamb
Copy link
Contributor

Just vagrant upd with the 8.7 release of drupal-project. Red 5, I'm going in.

@dannylamb
Copy link
Contributor

Alright, so, a bit of a red herring. It looked like even with the configuration set to expose /media/* urls, the REST endpoints were /media/*/edit, which wrecked everything. So I went through and refactored and put url generating function is IslandoraUtils and just call those from everywhere. Still no dice. Then I cleared my cache and everything worked just fine.

So the solution to this is to just add a cache clear after setting the variable in claw-playbook.

BUT not all is lost, as that refactor actually fixes #1095 🍾

I'll throw up PRs for things as I clean up. That refactor means I have to go touch up all the tests.

@whikloj
Copy link
Member

whikloj commented Jun 19, 2019

@dannylamb I thought that as well, but it is not true. If you change the configuration, then you need to clear the cache but the REST endpoints do also change.

@dannylamb
Copy link
Contributor

@whikloj I know right? Threw me for a loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants