Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header sizes should be relative to text size #201

Closed
CosmicHorrorDev opened this issue Dec 22, 2023 · 2 comments · Fixed by #307
Closed

Header sizes should be relative to text size #201

CosmicHorrorDev opened this issue Dec 22, 2023 · 2 comments · Fixed by #307
Labels
C-bug Category: Something isn't working E-easy Experience needed: Easy (good first issue)

Comments

@CosmicHorrorDev
Copy link
Collaborator

CosmicHorrorDev commented Dec 22, 2023

With the still-pedning-release text rewrite one of the unreleased changes caused header sizes to grow much smaller than the regular text's size now. The header sizes should be adjusted to reflect the new text size and should probably use multipliers to be more resilient to these kinds of changes in the future


Markdown

# H1
## H2
### H3
#### H4
##### H5
###### H6

Regular text

Rendered by GitHub

H1

H2

H3

H4

H5
H6

Regular text


Rendered by inlyne

image

@CosmicHorrorDev CosmicHorrorDev added C-bug Category: Something isn't working E-easy Experience needed: Easy (good first issue) labels Dec 22, 2023
@Valentin271
Copy link
Contributor

Maybe github renders differently on your screen, but on mine the text is actually equivalent to h4, meaning h5 and h6 are smaller. This is hard to see but looking at the CSS this is pretty clear.

  • h1: 2em
  • h2: 1.5em
  • h3: 1.25em
  • h4: 1em
  • h5: .875em
  • h6: .85em
  • text: 14px

I agree though that we should start using relative sizes for headers. We can probably align on github sizes.

@CosmicHorrorDev CosmicHorrorDev changed the title Header sizes can grow smaller than regular text Header sizes should be relative to text size Jan 27, 2024
@CosmicHorrorDev
Copy link
Collaborator Author

Well that's a TIL. Thanks for the investigation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working E-easy Experience needed: Easy (good first issue)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants