Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please review upgrade 48 #1617

Open
skenow opened this issue Jan 21, 2025 · 1 comment · May be fixed by #1619
Open

Please review upgrade 48 #1617

skenow opened this issue Jan 21, 2025 · 1 comment · May be fixed by #1619
Milestone
2.0.2

Comments

@skenow
Copy link
Contributor

skenow commented Jan 21, 2025

Changes made in #1616 placed the last dbversion update completely outside of the try-catch handling, different than all other version upgrades using this approach.
@skenow skenow added this to the 2.0.2 milestone Jan 21, 2025
@fiammybe
Copy link
Member

I changed that because the try-catch does not take into account that the removal of folders can fail because the folders are no longer there. (upgrading from a beta release for example) In that situation the upgrade to version 48 never happens.

I'll need to change the logic there a bit.

@fiammybe fiammybe linked a pull request Feb 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.2
Development

Successfully merging a pull request may close this issue.

fix:the DB update to v48 is now correctly positioned fiammybe/impresscms
2 participants
@skenow @fiammybe