Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel status messages should be sent before & after each shell request #311

Closed
takluyver opened this issue May 5, 2016 · 12 comments
Closed

Comments

@takluyver
Copy link
Member

We currently only send them on execution. I think the spec wasn't clear when we first wrote the code, but this was decided in message spec version 5:
http://jupyter-client.readthedocs.io/en/latest/messaging.html#kernel-status

This would be a relatively easy task if someone is looking to start contributing.

From jupyter/services#139

@jankatins
Copy link
Contributor

@parente, @takluyver Isn't this closed with the merge of #312?

@takluyver
Copy link
Member Author

Yep, thanks.

@enigmata
Copy link

@takluyver @JanSchulz any outlook on a new release incorporating this fix? we are using jupyter-js-services against R kernels and this makes it rather troublesome to use.

@jankatins
Copy link
Contributor

jankatins commented Jun 21, 2016

IMO we could send IRdisplay to CRAN and then IRKernel. Maybe implement IRkernel/IRdisplay#28 first (at least set 'jupyter.rich_display' in IRkernel), but the rest seems ok to ignore for a release.

@dockter-84
Copy link

Yes, I'm interested in incorporating the fix, too.

@enigmata
Copy link

@JanSchulz seems good. so how does this progress to closing on a new release? need to vote somewhere and slip bitcoins to somebody? ;-)

@enigmata
Copy link

@flying-sheep any comment on getting a release?

@flying-sheep
Copy link
Member

flying-sheep commented Jun 24, 2016

i seem to be a bit inactive in the last weeks, right? 😐

well, @JanSchulz has created milestones for both the kernel and IRdisplay. i’ll see if i get IRdisplay submitted to CRAN this weekend

@enigmata
Copy link

@flying-sheep how did things work out on the weekend? Are we rolling?

@flying-sheep
Copy link
Member

sorry, no

btw.: i’d like to get IRkernel/IRdisplay#19 fixed first.

@enigmata
Copy link

@flying-sheep @JanSchulz so now we're waiting on this one? IRkernel/IRdisplay#20

@flying-sheep
Copy link
Member

flying-sheep commented Jun 30, 2016

i think we’re basically waiting on IRkernel/IRdisplay#33 and #368.

it’s important to get this nailed down before we publish (clarify the packages’ area of responsibility)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants