Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the constraint violation error in DestroyDataseCommand (3875) #3876

Merged

Conversation

landreev
Copy link
Contributor

@landreev landreev commented Jun 1, 2017

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

…e doomed

dataset has an explicitly assigned thumbnail DataFile.
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of 0ecdd35 all of the tests in DatasetsIT.java pass. Looks like a good fix. Approved.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0002%) to 10.039% when pulling 0ecdd35 on 3875-destroy-dataset-thumbnail-datafile-constraint into f6441f8 on develop.

@kcondon kcondon merged commit a9c5354 into develop Jun 1, 2017
@kcondon kcondon deleted the 3875-destroy-dataset-thumbnail-datafile-constraint branch June 1, 2017 19:56
@pdurbin pdurbin added this to the 4.6.2 - Tabular Mapping milestone Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants