Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep or make editable the order of entries in the metadataLanguage dropdown list #8588

Closed
tjouneau opened this issue Apr 8, 2022 · 3 comments

Comments

@tjouneau
Copy link

tjouneau commented Apr 8, 2022

What steps does it take to reproduce the issue?
Configure a list of languages by populating the :MetadataLanguages setting.
curl http://localhost:8080/api/admin/settings/:MetadataLanguages -X PUT -d '[{"locale":"en","title":"Anglais (English)"},{"locale":"fr","title":"Français (French)"},{"locale":"de","title":"Allemand (German)"},{"locale":"es","title":"Espagnol (Spanish)"},{"locale":"it","title":"Italien (Italian)"},{"locale":"pt","title":"Portugais (Portuguese)"}]'
Consider the order in which they appear at dataset creation.
image001

  • When and on which page(s) does this issue occur?
    At dataset creation.

  • What happens?
    The order in which they appear does not correspond to the one in the request, nor the alphabetical order of "locale" or "title".

  • To whom does it occur (all users, curators, superusers)?
    All users

  • What did you expect to happen?
    The order of the array sent to the :MetadataLanguages setting should ideally be kept. In our use case, we would prefer English and French to appear first.

Which version of Dataverse are you using?
5.10

Any related open or closed issues to this bug report?
None identified.

@tjouneau tjouneau changed the title Keep or make editable the order of entries in the metadatLanguage dropdown list Keep or make editable the order of entries in the metadataLanguage dropdown list Apr 20, 2022
@pdurbin
Copy link
Member

pdurbin commented Oct 4, 2022

@tjouneau thanks for letting us know at #4632 (comment) that

"TBH we only retained two languages, English and French."

Does that mean you don't really worry about the order anymore?

@tjouneau
Copy link
Author

tjouneau commented Oct 4, 2022

@pdurbin We originally restrained this because of the order not being editable, that's true. I still think it would be better to have a default language and an editable order afterwards.
As for us specifically, as we are on a path to merge into recherche.data.gouv.fr eventually, I think we will content ourselves with what exists.

@tjouneau tjouneau closed this as completed Oct 4, 2022
@pdurbin
Copy link
Member

pdurbin commented Oct 4, 2022

@tjouneau ok. Sounds good. Please do feel free to create a fresh issue in the future! A default language and an editable order afterwards makes sense to me. Or maybe simply the order in the JSON that is sent in the setting, as you suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants