-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gson, Jackson and Everit JSON Schema Validation code dependencies #6810
Comments
Related: Increasingly slow feedback loop for developers, increasingly large WAR files #5593 |
Lately, I came back to look into #6694 now that we are on Payara 5 and can use Jakarta JSON-B standard now. This issue should be done before. This refactoring should cleanup the direct dependency on Will adapt the title accordingly. |
… provides it for us. IQSS#6810
Back in the days of IQSS#2290 (2016), code for JSON serialization has been introduced. This has never been used, all DataFile objects are still serialized as JSON by util.JsonPrinter. Removing this 4 year old, completely unused code. If used in the future again, this should be done based on Jakarta JSON-B.
… All setters left to go. IQSS#6810
I gave this issue a shout out today: https://iqss.slack.com/archives/C010LA04BCG/p1697654377221549?thread_ts=1697642617.029569&cid=C010LA04BCG |
@poikilotherm in Zulip, I just saw you write this: "I can't help it: I think we need to get rid of the JsonPrinter/JsonReader classes, as described in #6810" I thought this issue was mostly about removing the dependencies on third-party JSON libraries (Gson, Jackson, etc.) when we already have one that comes with Jakarta EE. It's also about removing the JsonPrinter/JsonReader classes? Should that be a separate issue? |
Yeah, it might be it's own issue to split the tasks. On the other hand it is very often not easy to distinguish between these things, as there are code places where a few of the techs plus our own things mix and match. |
To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'. If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment. |
I'm reviewing #10739 and actively suggesting we not dig ourselves in deeper with Gson. Let's use the platform we build on (Jakarta EE) instead. In short, I agree with @poikilotherm so I'll reopen this issue. |
A lot of places in the code base use the Gson or Jackson library to do JSON processing (and a bit of data binding).
These should be refactored to use Java EE JSON-P (around since EE7) and JSON-B instead, making the code base using more standards and lowering no of deps.
This is related to #4260
The text was updated successfully, but these errors were encountered: