Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File page doesn't show external tools for other mimetypes #5577

Closed
qqmyers opened this issue Feb 26, 2019 · 0 comments
Closed

File page doesn't show external tools for other mimetypes #5577

qqmyers opened this issue Feb 26, 2019 · 0 comments
Assignees
@kcondon
Milestone
4.12

Comments

@qqmyers
Copy link
Member

qqmyers commented Feb 26, 2019 •
edited
Loading

It looks like I missed the change to FilePage required to show external tools for other mimetypes in responding to comments on #5456, and because of that, I then incorrectly removed a filter to retrieve only the external tools for a given mimetype, which is needed for the FilePage. I'll submit a PR that fixes this...
@qqmyers qqmyers changed the title File page shows all external tools File page doesn't show external tools for other mimetypes Feb 26, 2019
@qqmyers qqmyers mentioned this issue Feb 26, 2019
Merged
5 tasks
@scolapasta scolapasta removed their assignment Feb 27, 2019
@kcondon kcondon self-assigned this Feb 28, 2019
@kcondon kcondon closed this as completed Feb 28, 2019
@djbrooke djbrooke added this to the 4.12 milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.12
Development

No branches or pull requests
4 participants
@scolapasta @kcondon @qqmyers @djbrooke