-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modifyRegistration API calls to only update when necessary #5505
Labels
Feature: DOI & Handle
GREI 2
Consistent Metadata
Size: 3
A percentage of a sprint. 2.1 hours.
Type: Suggestion
an idea
Milestone
Comments
This was referenced Jan 31, 2019
Closed
Hi @qqmyers - just making sure you saw the note from @sekmiller in the PR here: |
@djbrooke - thanks - just being slow / finding new issues :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature: DOI & Handle
GREI 2
Consistent Metadata
Size: 3
A percentage of a sprint. 2.1 hours.
Type: Suggestion
an idea
The /modifyRegistrationPIDMetadataAll and {id}/modifyRegistrationMetadata api call implementations (which actually update the metadata and targetURL) currently do not check to see whether updates are needed before sending change requests to the provider. This makes their use as a way to correct errors in the metadata and/or targetUrl problematic as they would also try to update PIDs that don't need any change. (See, for example, #5144 and #4760).
The DataCite DOI provider is one that provides an API to retrieve the current targetURL and metadata, making it possible to check before updating. It would be helpful if the Abstract classes for providers differentiated between first time registration and updates and for the DataCite DOI provider to perform checks when updating. (PR to follow).
The text was updated successfully, but these errors were encountered: