Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding persistent temp files #5089

Closed
qqmyers opened this issue Sep 25, 2018 · 2 comments
Closed

Avoiding persistent temp files #5089

qqmyers opened this issue Sep 25, 2018 · 2 comments
Assignees

Comments

@qqmyers
Copy link
Member

qqmyers commented Sep 25, 2018

Working on behalf of TDL, I've found one case for shapefile zips where a successful upload leaves temporary files in the defined temp directory and several ways that user actions to delete or cancel when uploading can cause temp file to remain. I've gone through the code and have changes to submit.

The only cases I'm aware of where 'persistent' temp files can still be created would be 1) where network errors break the communication with the browser and neither a save or cancel is ever received, and 2) some code that writes directly to subdirs under /tmp (eg. some of the R code) which is nominally cleaned up by the operating system.

@pdurbin
Copy link
Member

pdurbin commented Sep 25, 2018

@qqmyers thanks for opening this issue! Perhaps we'll close some of these related issues in favor of this one that you just opened: #2125 #2140 #2848 #3818

@qqmyers
Copy link
Member Author

qqmyers commented Sep 25, 2018

@pdurbin - this is probably closest to #2140, not sure of the overlap on the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants