Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File cards in search should link to new File page #3555

Closed
raprasad opened this issue Jan 4, 2017 · 4 comments
Closed

File cards in search should link to new File page #3555

raprasad opened this issue Jan 4, 2017 · 4 comments
Labels
Feature: My Data Feature: Search/Browse Type: Suggestion an idea

Comments

@raprasad
Copy link
Contributor

raprasad commented Jan 4, 2017 •
edited by djbrooke
Loading

No description provided.

@raprasad raprasad added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Jan 4, 2017
@raprasad raprasad changed the title MyDat file cards should link to new File page MyData file cards should link to new File page Jan 4, 2017
@mheppler mheppler mentioned this issue Jan 5, 2017
Closed
3 tasks
@djbrooke djbrooke changed the title MyData file cards should link to new File page File cards in search should link to new File page Jan 26, 2017
@djbrooke djbrooke added ready and removed Component: Code Infrastructure formerly "Feature: Code Infrastructure" ready labels Jan 31, 2017
@mheppler mheppler mentioned this issue Jun 16, 2017
Closed
@raprasad
Copy link
Contributor Author

  • mydata, link file card to file page
    • file: cards_miniumum.html
    • line #: 26
    • example update:
            <a href="/file.xhtml?fileId={{ card_info.entity_id }}"><span style="padding:4px 0;">{{ card_info.name }}</span></a>

@mheppler
Copy link
Contributor

mheppler commented Jun 20, 2017 •
edited
Loading

The fix for navigating from the dataverse pg results cards for a file to the file pg has been fixed with the work done in Customization Header/Footer/Homepage - Optional new landing page for installation #3639, removing the ShowFileLandingPage setting from the search-include and related files.

This issue will remain open, to fix the My Data pg, once the bug in MyData: clicking files facet hangs/gives error (added in 4.6.2) #3886 is resolved.

@raprasad
Copy link
Contributor Author

raprasad commented Jun 20, 2017 •
edited by mheppler
Loading

@mheppler : I added the MyData file card fixes into #3886.

  • e.g. The links in the MyData File card now go to the file page.

@mheppler
Copy link
Contributor

Closing this issue as delivered in #3866 by @raprasad. 👍

@mheppler mheppler mentioned this issue Jun 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: My Data Feature: Search/Browse Type: Suggestion an idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pdurbin @mheppler @raprasad @djbrooke