-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customizable copyright footer #3379
Comments
#2003 is related and currently has a milestone of 4.6. When @tdilauro visited a few months back he talked about how he tweaked the footer to add information that presumably currently lives in their DVN 3.x instance at https://archive.data.jhu.edu/dvn/ (he also added a Johns Hopkins banner to the top, he said). |
I made a minimal pull request at #3380 to show the part of the code that needs to change. Docs and tests need to be added. |
@mheppler and I discussed 242080d this morning and there a few things we'd like to address:
|
I just rolled the dynamic copyright year issue (#2905) into my pull request for this issue (#3380) since they are so closely related. @djbrooke indicated that if the fixes are trivial they could be given a milestone of 4.5.1, which I just did. I also documented the setting in the installation guide. I didn't address the performance concern. I'm not actually sure if settingsWrapper.get performance stuff is compatible with how I'm doing things. @scolapasta would know. At https://waffle.io/IQSS/dataverse I'm moving this to QA since I'm happy with the solutions. |
Discussed with @pdurbin and @djbrooke on moving the dynamic copyright features developed as part of this issue, into issue #2905 and send that to QA for 4.5.1. Then, this issue will remain open for a later release, so that we can gather additional input from other installations on how they'd like to further customize the footer with custom text, images, layout, etc. |
Also use `settingsWrapper.get` for better performance.
This issue is being closed in favor of a new issue, so that it can be easily tracked through development.
Thank you for your input @donsizemore! Please check those new issues to make sure that we are covering your requested features. |
Thu-Mai would like for us to be able to protect the Odum and UNC names and logos, in addition to anything that doesn't have established user terms. This may better be tacked on to issue #2905.
The text was updated successfully, but these errors were encountered: