Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Access: Edge case where request access button does not appear using custom role for unpublished, restricted file. #2711

Closed
kcondon opened this issue Oct 29, 2015 · 2 comments
Labels
Feature: File Upload & Handling Feature: Permissions Feature: Request Access Workflow Type: Bug a defect User Role: Guest Anyone using the system, even without an account UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@kcondon
Copy link
Contributor

kcondon commented Oct 29, 2015

See test case 3 at: #2648

Request Access: Button does not appear for file, does not become disable when pressed for unpublished, restricted file where user has special view unpublished dataset only perm.

Using an unpublished dataset with two files, one restricted, one unrestricted
Verify view unpublished dataset grants downloading unrestricted file but not restricted unpublished file, until file downloader perm is also granted. using the above test dataset and files, create a special role at the datateverse level that has only view unpublished dataset. Grant to user. Verify they can view dataset and all file access buttons appear: request access for restricted file (make sure allow request access is enabled), and download for the unrestricted file. Make sure you can download unrestricted file. Verify you can download unrestricted file and get 403 with restricted file via API.

@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: Medium Feature: File Upload & Handling Type: Bug a defect labels Oct 29, 2015
@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@eaquigley
Copy link
Contributor

Discussed with @kcondon and am sending this back to him to retest and see if it is still happening.

@kcondon kcondon changed the title Request Access: Button does not appear for file, does not become disable when pressed for unpublished, restricted file where user has special view unpublished dataset only perm. Request Access: Edge case where request access button does not appear using custom role for unpublished, restricted file. Jan 5, 2016
@kcondon
Copy link
Contributor Author

kcondon commented Jan 5, 2016

Retested above test case and found it mostly works with the exception of the request access button not appearing for custom role without file download perm.

Works:
Custom role having only view unpublished dataset permission but without the file download permission (like member without file download).
Can see unpublished dataset, can download unrestricted file, downloading all does not download restricted file, says restricted/ not allowed in manifest, downloading restricted file only with download selected button throws 403 error, not allowed.

Does not work:
request access button does not appear even though allow request access is enabled.

@kcondon kcondon removed their assignment Jan 5, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@pdurbin pdurbin added the User Role: Guest Anyone using the system, even without an account label Jul 12, 2017
@pdurbin pdurbin closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling Feature: Permissions Feature: Request Access Workflow Type: Bug a defect User Role: Guest Anyone using the system, even without an account UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

6 participants