Update README.md #583
Merged
Update README.md #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To the list of changes that the SPA introduces, this adds that Dataverses are called referred to as collections, instead
g-saracca
previously approved these changes
Jan 13, 2025
pdurbin
reviewed
Jan 13, 2025
There was a problem hiding this comment.
I'll let the frontend team approve this but it looks good to me!
One thought is that we could also reword the #### Dataverses/Datasets list item above to talk about collections instead of dataverses. This could be in a separate PR if we wish.
Also, I'm not sure how this items are ordered but this new one (#### Dataverses are Called Collections) probably belongs at or at least near the top.
ChengShi-1
previously approved these changes
Jan 13, 2025
|
@pdurbin I've implemented your docs suggestions, take a look please and approve it if you think its ok. Thanks! |
|
proof-read, merging pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To the list of changes that the SPA introduces, this PR adds that Dataverses are referred to as collections, instead.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
This PR doesn't introduce a user interface change
Is there a release notes update needed for this change?:
I don't think a release note is needed for this change.