Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection page: add dataset thumbnail to the item card #582

Merged

Conversation

ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Jan 13, 2025

What this PR does / why we need it:

For Q4.2, the goal is to complete the missing information on the cards in collection page. There is no thumbnails to items so we need add them.

Which issue(s) this PR closes:

Special notes for your reviewer:

The tests are written already, so there is no test added. DatasetCardThumbnail.spec.tsx

package.json should be removed after js-dataverse version updated

Suggestions on how to test this:

  • create a dataset in SPA
  • add a thumbnail from JSF
  • test if the thumbnail for the dataset is shown in SPA

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes, in collection page, if there is a thumbnail uploaded by user, then the dataset thumbnail should be shown.

Is there a release notes update needed for this change?:

No

@ChengShi-1 ChengShi-1 linked an issue Jan 13, 2025 that may be closed by this pull request
@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q4.2 Collection Page: Extended item cards information FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) labels Jan 13, 2025
@coveralls
Copy link

coveralls commented Jan 13, 2025

Coverage Status

coverage: 97.299% (-0.02%) from 97.315%
when pulling d81522f on 579-collection-page-add-dataset-thumbnail-to-the-card-item
into 66fd102 on develop.

@ChengShi-1 ChengShi-1 self-assigned this Jan 13, 2025
@ChengShi-1 ChengShi-1 removed their assignment Jan 14, 2025
@ChengShi-1 ChengShi-1 marked this pull request as ready for review January 14, 2025 20:32
@cmbz cmbz added the FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) label Jan 15, 2025
@g-saracca g-saracca self-assigned this Jan 16, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approving!
This is the PR from the removed TODO comment, maybe after this is merged could be closed also?

@g-saracca g-saracca removed their assignment Jan 17, 2025
@ChengShi-1
Copy link
Contributor Author

ChengShi-1 commented Jan 17, 2025

Looks good, approving! This is the PR from the removed TODO comment, maybe after this is merged could be closed also?

I guess they are different since this PR is for collection page item card, but it doesn't work for dataset view page. The issue you mention may related to the dataset view page(currently still default image)
image
image

@g-saracca
Copy link
Contributor

g-saracca commented Jan 17, 2025

I guess they are different since this PR is for collection page item card, but it doesn't work for dataset view page. The issue you mention may related to the dataset view page(currently still default image)

You are correct, thanks!

@ofahimIQSS ofahimIQSS self-assigned this Jan 17, 2025
@ofahimIQSS
Copy link
Contributor

image
Test Passed, Merging PR

@ofahimIQSS ofahimIQSS merged commit f8b68c4 into develop Jan 17, 2025
10 of 14 checks passed
@ofahimIQSS ofahimIQSS deleted the 579-collection-page-add-dataset-thumbnail-to-the-card-item branch January 17, 2025 21:11
@ofahimIQSS ofahimIQSS removed their assignment Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA.Q4.2 Collection Page: Extended item cards information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection Page: Add dataset thumbnail to the card item
5 participants