-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection page: add dataset thumbnail to the item card #582
Collection page: add dataset thumbnail to the item card #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approving!
This is the PR from the removed TODO comment, maybe after this is merged could be closed also?
I guess they are different since this PR is for collection page item card, but it doesn't work for dataset view page. The issue you mention may related to the dataset view page(currently still default image) |
You are correct, thanks! |
What this PR does / why we need it:
For Q4.2, the goal is to complete the missing information on the cards in collection page. There is no thumbnails to items so we need add them.
Which issue(s) this PR closes:
Special notes for your reviewer:
The tests are written already, so there is no test added. DatasetCardThumbnail.spec.tsx
package.json should be removed after js-dataverse version updated
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, in collection page, if there is a thumbnail uploaded by user, then the dataset thumbnail should be shown.
Is there a release notes update needed for this change?:
No