-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection page show lock/unlock icon for restricted files in the card #576
Merged
ofahimIQSS
merged 6 commits into
develop
from
548-collection-page-show-lockunlock-icon-for-restricted-files-in-the-card
Jan 15, 2025
Merged
Collection page show lock/unlock icon for restricted files in the card #576
ofahimIQSS
merged 6 commits into
develop
from
548-collection-page-show-lockunlock-icon-for-restricted-files-in-the-card
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some questions.
tests/component/sections/collection/collection-items-panel/file-card/FileCard.spec.tsx
Show resolved
Hide resolved
g-saracca
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 14
FY25 Sprint 14 (2025-01-02 - 2025-01-15)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Collection Page
SPA.Q1
Not related to any specific Q1 feature
SPA.Q4.2
Collection Page: Extended item cards information
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In collection page, lock/unlock icon is missing so this PR aims to adding the icon into every restricted file.
Which issue(s) this PR closes:
Special notes for your reviewer:
wait for the IQSS/dataverse-client-javascript#234 to be merged
In FilePreview model
Only these two is related to the lock/unlock icon, the other fields would be added from other issue. #564
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here: