fix: bugs

IQSS · Feb 21, 2025 · f84a677 · f84a677
1 parent b4fc949
commit f84a677
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 3 deletions.
diff --git a/src/sections/contact/ContactButton.tsx b/src/sections/contact/ContactButton.tsx
@@ -60,7 +60,7 @@ export const ContactButton = ({
           <ContactModal
             show={showContactModal}
             handleClose={closeContactModal}
-            title={t('contact.contactCollection')}
+            title={t('contact.contactDataset')}
             onSuccess={onSuccess}
             toContactName={toContactName}
             id={id}

diff --git a/tests/component/sections/contact/ContactButton.spec.tsx b/tests/component/sections/contact/ContactButton.spec.tsx
@@ -14,13 +14,30 @@ describe('ContactButton', () => {
         contactRepository={contactRepository}
       />
     )
-
     cy.findByRole('button', { name: /Contact/i })
       .should('exist')
       .click()
   })
   it('shows contact button if it is in collection page ', () => {
     cy.findByRole('dialog').should('exist')
+    cy.findByText(/Email Collection Contact/i).should('exist')
+  })
+
+  it('shows contact button if it is in collection page with numeric id', () => {
+    cy.customMount(
+      <ContactButton
+        onSuccess={() => {}}
+        toContactName="Test Dataset"
+        isCollection={true}
+        id={1}
+        contactRepository={contactRepository}
+      />
+    )
+
+    cy.findByRole('button', { name: /Contact/i })
+      .should('exist')
+      .click()
+    cy.findByRole('dialog').should('exist')
   })
 
   it('shows contact owner button if it is in dataset page ', () => {
@@ -36,6 +53,7 @@ describe('ContactButton', () => {
     cy.findByRole('button', { name: /Contact Owner/i })
       .should('exist')
       .click()
+    cy.findByText(/Email Dataset Contact/i).should('exist')
     cy.findByRole('dialog').should('exist')
   })
 
@@ -93,3 +111,39 @@ describe('ContactButton', () => {
     cy.findByRole('dialog').should('not.exist')
   })
 })
+
+describe('ContactButton Error', () => {
+  it('should send alert if the submission is failed', () => {
+    const contactRepository = new ContactJSDataverseRepository()
+    cy.stub(ContactJSDataverseRepository.prototype, 'submitContactInfo').rejects(new Error('Error'))
+    cy.customMount(
+      <ContactButton
+        onSuccess={() => {}}
+        toContactName="Test Dataset"
+        isCollection={true}
+        id="root"
+        contactRepository={contactRepository}
+      />
+    )
+
+    cy.findByRole('button', { name: /Contact/i })
+      .should('exist')
+      .click()
+    cy.findByTestId('captchaNumbers')
+      .invoke('text')
+      .then((text) => {
+        const matches = text.match(/(\d+)\s*\+\s*(\d+)\s*=/)
+        if (matches) {
+          const num1 = parseInt(matches[1], 10)
+          const num2 = parseInt(matches[2], 10)
+          const answer = num1 + num2
+          cy.findByTestId('fromEmail').type('email@dataverse.com')
+          cy.findByTestId('subject').type('subject')
+          cy.findByTestId('body').type('message')
+          cy.findByTestId('captchaInput').type(answer.toString())
+          cy.findByRole('button', { name: /Submit/i }).click()
+        }
+      })
+    cy.findByText('Error').should('exist')
+  })
+})
diff --git a/tests/component/sections/dataset/Dataset.spec.tsx b/tests/component/sections/dataset/Dataset.spec.tsx
@@ -340,6 +340,6 @@ describe('Dataset', () => {
         }
       })
     cy.findByRole('dialog').should('not.exist')
-    cy.findByText('Success!').should('exist')
+    cy.findByText(/Message sent./).should('exist')
   })
 })