Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: spoon-bot should delete old Revapi reports #1426

Closed
monperrus opened this issue Jun 24, 2017 · 3 comments · Fixed by #1863
Closed

chore: spoon-bot should delete old Revapi reports #1426

monperrus opened this issue Jun 24, 2017 · 3 comments · Fixed by #1863
Labels

Comments

@monperrus
Copy link
Collaborator

spoon-bot should post a Revapi comment only if the computed API change are different from the last post.

Possible implementation, in revapy.py, use the Github API to go over the list of comments to the PR and compare them against the newly computed one.

@monperrus monperrus changed the title chore: spoon-bot should post a Revapi comment only if the API change are new chore: spoon-bot should post a Revapi comment only if the API changes are new Jun 24, 2017
@surli surli added the chore label Jun 26, 2017
@monperrus
Copy link
Collaborator Author

@surli would you have a look at this one?

@pvojtechovsky
Copy link
Collaborator

How it should behave when
1st commit has a revapi changes
2nd later commit fixes compatibility problems and there is NO revapi change

In such case there will stay old confusing revapi report.

Idea:

  1. each CI run should always delete old revapi changes
  2. and generate new one if ther is a revapi change - same like now - or add nothing if there is no change.

@surli
Copy link
Collaborator

surli commented Nov 10, 2017

The solution proposed in #1683 is not working

@surli surli reopened this Nov 10, 2017
@monperrus monperrus changed the title chore: spoon-bot should post a Revapi comment only if the API changes are new chore: spoon-bot should delete old Revapi reports Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants