-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prezi editorial notes #1836
Comments
Commenting on @azaroth42's comments and also adding some more:
I think compound is better than composite, as although they mean pretty much the same thing, there is more of a suggestion that each part is different in composite ("a composite material") than in compound. Hundreds of canvases feel more compound that composite. Suggestion for reorganising the current first three paras:
(and structured -> compound later) General point
Lower case I think, but 2.2 is a bit problematic in its use of "type". In 2.1 the headings describing each type are also the values of 2.1. (Collection) Maybe just:-
...and rely on later definitions (and their examples) to make it clear that "descriptive information" can be used (the spec reader would hope so!) (Comments)
cf. 5.2: "The Manifest resource typically represents a single object..." 3 (intro)
Is that para necessary? Given what's been said already. 3.1.requiredStatement - that the +publishing organization deems ... ? 3.1.provider - here "string that contains a URI", compare to rights where "string must be a URI". Prefer be a, not contain a. 3.1.thumbnail - is "external resource" necessary to specify? Just resource? Probably comes from it being previously under external links in 3.3.1
3.1.thumbnail - images and video_s_ ? Doesn't read oddly as-is to me. Can we appeal to a higher authority for style? 3.thumbnail - In Canvas we use "representation" meaning the view. Ambiguous with web architecture use of representation? Or: 3.1. navdate - is "a time-based user interface" now ambiguous that we have temporal content resources? Change to 'date' based? date-based is ambiguous too, but better, and sufficient here, and echoes nav_Date_ 3.1.placeholder/accompanying Canvas value definition should define the value of type to be Canvas? For the two xxxCanvas: The value MUST be a JSON object with the 3.2.id is the bold for embedded and referenced needed? 3.2.type Does the table need a title or further reference, other than the second para in the prose? 3.2.format -- should the note be called out as a note block, or is plain text sufficient? 3.3.1.* -- drop "external" ? 3.3.1.seeAlso -- "Other IIIF resources, such as a related Manifest, are valid targets for seeAlso. " Is that really true?? Use cases
3.3.2 -- has the wrong label of 3.4.2 3.3.2.partOf -- is it clear that this is an external but IIIF resource, rather than within a single manifest document?
I don't think they should be removed, but they should have some catch-all formulation after the important usages have been called out, that acknowledges the full range of possibilities can be seen in the table. |
I think 1.2 would be a more formal place for the definition, but that by removing it from 3, the chances that the people who need to read it actually /do/ read it is reduced. Also, we don't define a bunch of other low level terms like API and whatever. So I would leave it as is, rather than trying to be more explicit.
Lets split out style from content changes to a different issue?
I think the first sentence of
I think it's useful to repeat it, as readers might skim the paragraph and go straight to the definition of the syntax that they're used to from all the other properties.
I would read image content / video content, or images / videos meaning the files. |
Compare all of the other tables which are at the end of their sections and also the tables in the Image API. I think we should defer and compare across the other tables.
I think all of those are fine, but non-IIIF to non-IIIF is a bit out of scope, if not going to break anything. |
What's the use case for asserting |
Having put the format/formats paragraph into a .note class, it looks really terrible due to the bullet list and example and note all having different indents. Taking it out. |
Closed by #1850 |
Editorial changes suggested from read-through:
type
to beCanvas
?type
to beImage
? (c.f.supplementary
)type
is not mandatoryThe text was updated successfully, but these errors were encountered: