-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about approach for sequences in v3 #81
Comments
Given that manifesto is an abstraction, I'd be inclined to agree with both implementations. Having a In that scenario we could build on the functionality of ranges and use them, as you say, as though they were sequences. It also raises the question that @edsilv has asked before about whether some of the utilities in Manifold should be part of manifesto. There is a lot of range construction and parsing there that could fit into this too. @mejackreed do you know if the |
Hi guys, the reason I made the changes in #79 of returning only top level canvases of the range, was because ranges with |
From https://iiif.io/api/presentation/3.0/#54-range
That makes me think that we can make the assumption that behavior == sequence ranges should function like v2 ranges and are not nested. |
That sounds easy enough, so maybe all we need is a |
And then with your changes @MImranAsghar in #79 we should have enough to gather the running order of the canvases. |
One question that came to mind was should |
Would the opposite work too? Returning Presentation 2 sequences as ranges as a way of moving forward with support for Presentation 3 as the mental model? |
Yes, that could also work. I think we should determine how maybe manifesto wants to assert this going forward? To get all of the sequence like things should I? manifestoInstance.getSequences()
// or
manifestoInstance.getRanges().filter(r => r.getBehavior() == 'sequence')
// or both? And should these have similar returns?
|
I think using both would be okay too in case of v3 and just getSequences in case of v2. |
Hi guys, I was wondering what you guys are thinking as final decision on this to proceed? I would love to work on any further changes that need to be made if that's okay. |
I gave something similar a try here #84 which we can use in combo with #79 . Here |
Hi @stephenwf , did you get a chance to look at the above two pull requests? |
I would be happy to help out on how manifesto might approach sequences in Prezi v3.
The two approaches I've thought about:
Range
to behave more like aSequence
is there the desire to move that direction?getSequences
to be able to parse v3 ranges that have the behaviorsequence
and returnSequence
?Has anyone else been thinking about support of this?
An example of a manifest hand crafted w/ v3 range sequences: https://gist.githubusercontent.com/mejackreed/a0c7e3ce7990042b2842980d136371d7/raw/manifest.json
The text was updated successfully, but these errors were encountered: