From 8b9c456fd7a884b0371e9ce01d69fee13aee9eea Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Fri, 9 Aug 2024 17:30:54 -0500 Subject: [PATCH 1/7] Consistent ARIA landmark help refs --- .../help-v4/en-US/aria_banner_single.html | 3 ++- .../help-v4/en-US/aria_toolbar_label_unique.html | 3 ++- .../src/v4/rules/aria_toolbar_label_unique.ts | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/accessibility-checker-engine/help-v4/en-US/aria_banner_single.html b/accessibility-checker-engine/help-v4/en-US/aria_banner_single.html index facf0c030..ded0553f7 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_banner_single.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_banner_single.html @@ -76,7 +76,8 @@

### About this requirement * [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) -* [ARIA practices - HTML Sectioning Elements](https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/#htmlsectioningelements) +* [ARIA practices - Landmark Regions](https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/) +* [ARIA specification - Banner Role](https://www.w3.org/TR/wai-aria-1.2/#banner)] ### Who does this affect? diff --git a/accessibility-checker-engine/help-v4/en-US/aria_toolbar_label_unique.html b/accessibility-checker-engine/help-v4/en-US/aria_toolbar_label_unique.html index fed43c1e9..b93fd2003 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_toolbar_label_unique.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_toolbar_label_unique.html @@ -79,8 +79,9 @@

Complex tools

### About this requirement -* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2) +* [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) * [ARIA16: aria-labelledby to name user interface controls](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA16) +* [ARIA specification - Toolbar Role](https://www.w3.org/TR/wai-aria-1.2/#toolbar) ### Who does this affect? diff --git a/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts b/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts index 729c8ed10..d0d8cbe83 100644 --- a/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts +++ b/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts @@ -40,7 +40,7 @@ export let aria_toolbar_label_unique: Rule = { }, rulesets: [{ "id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"], - "num": ["4.1.2"], + "num": ["2.4.1"], //updated mapping to match other landmark regions rules "level": eRulePolicy.VIOLATION, "toolkitLevel": eToolkitLevel.LEVEL_ONE }], From 32af1341a78d2f3c6e796d97e2d9aa11b9c5002c Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Fri, 9 Aug 2024 18:15:44 -0500 Subject: [PATCH 2/7] only one per page --- .../src/v4/rules/aria_banner_single.ts | 4 ++-- .../src/v4/rules/aria_contentinfo_misuse.ts | 4 ++-- .../src/v4/rules/aria_contentinfo_single.ts | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/accessibility-checker-engine/src/v4/rules/aria_banner_single.ts b/accessibility-checker-engine/src/v4/rules/aria_banner_single.ts index 65b1e4105..8f1f26ade 100644 --- a/accessibility-checker-engine/src/v4/rules/aria_banner_single.ts +++ b/accessibility-checker-engine/src/v4/rules/aria_banner_single.ts @@ -33,8 +33,8 @@ export let aria_banner_single: Rule = { messages: { "en-US": { "Pass_0": "Rule Passed", - "Fail_1": "There is more than one element with \"banner\" role on the page", - "group": "There must be only one element with \"banner\" role on the page" + "Fail_1": "Multiple elements with \"banner\" role found on the page", + "group": "A page, document, or application should only have one element with \"banner\" role" } }, rulesets: [{ diff --git a/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts b/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts index 137811bee..5e553b59e 100644 --- a/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts +++ b/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts @@ -34,8 +34,8 @@ export let aria_contentinfo_misuse: Rule = { messages: { "en-US": { "Pass_0": "Rule Passed", - "Fail_1": "The element with \"contentinfo\" role is present without an element with \"main\" role", - "group": "An element with \"contentinfo\" role is only permitted with an element with \"main\" role" + "Fail_1": "Element with \"contentinfo\" role is present without an element with \"main\" role", + "group": "Each element with \"contentinfo\" role is only permitted within an element with \"main\" role" } }, rulesets: [{ diff --git a/accessibility-checker-engine/src/v4/rules/aria_contentinfo_single.ts b/accessibility-checker-engine/src/v4/rules/aria_contentinfo_single.ts index 4058938f8..946fca5fd 100644 --- a/accessibility-checker-engine/src/v4/rules/aria_contentinfo_single.ts +++ b/accessibility-checker-engine/src/v4/rules/aria_contentinfo_single.ts @@ -33,8 +33,8 @@ export let aria_contentinfo_single: Rule = { messages: { "en-US": { "Pass_0": "Rule Passed", - "Fail_1": "Multiple elements with \"contentinfo\" role found on a page", - "group": "A page, document or application should only have one element with \"contentinfo\" role" + "Fail_1": "Multiple elements with \"contentinfo\" role found on the page", + "group": "A page, document, or application should only have one element with \"contentinfo\" role" } }, rulesets: [{ From 5f9497b74225519d3f07a99da3efc9ecf24cdf08 Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Mon, 12 Aug 2024 17:40:48 -0500 Subject: [PATCH 3/7] Update messages --- .../src/v4/rules/aria_contentinfo_misuse.ts | 2 +- .../src/v4/rules/aria_toolbar_label_unique.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts b/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts index 5e553b59e..432a3049f 100644 --- a/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts +++ b/accessibility-checker-engine/src/v4/rules/aria_contentinfo_misuse.ts @@ -35,7 +35,7 @@ export let aria_contentinfo_misuse: Rule = { "en-US": { "Pass_0": "Rule Passed", "Fail_1": "Element with \"contentinfo\" role is present without an element with \"main\" role", - "group": "Each element with \"contentinfo\" role is only permitted within an element with \"main\" role" + "group": "Each element with \"contentinfo\" role is only permitted with an element with \"main\" role" } }, rulesets: [{ diff --git a/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts b/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts index d0d8cbe83..d602f27b1 100644 --- a/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts +++ b/accessibility-checker-engine/src/v4/rules/aria_toolbar_label_unique.ts @@ -34,8 +34,8 @@ export let aria_toolbar_label_unique: Rule = { messages: { "en-US": { "Pass_0": "Rule Passed", - "Fail_1": "Multiple toolbar components do not have unique labels", - "group": "All toolbar components on a page must have unique labels specified" + "Fail_1": "Multiple elements with \"toolbar\" roles do not have unique labels", + "group": "Each element with \"toolbar\" role must have a unique label that describes its purpose" } }, rulesets: [{ From 2ea0fd3508ed2d14dc9d0d475c018712f1474985 Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Tue, 13 Aug 2024 10:51:39 -0500 Subject: [PATCH 4/7] consistent messages and help --- .../help-v4/en-US/aria_application_label_unique.html | 1 + .../help-v4/en-US/aria_application_labelled.html | 1 + .../help-v4/en-US/aria_article_label_unique.html | 1 + .../help-v4/en-US/aria_banner_label_unique.html | 1 + .../help-v4/en-US/aria_complementary_label_unique.html | 1 + .../en-US/aria_complementary_label_visible.html | 1 + .../help-v4/en-US/aria_contentinfo_label_unique.html | 6 +++++- .../help-v4/en-US/aria_document_label_unique.html | 1 + .../help-v4/en-US/aria_form_label_unique.html | 1 + .../help-v4/en-US/aria_landmark_name_unique.html | 1 + .../help-v4/en-US/aria_main_label_unique.html | 2 +- .../help-v4/en-US/aria_main_label_visible.html | 1 + .../help-v4/en-US/aria_navigation_label_unique.html | 1 + .../help-v4/en-US/aria_region_label_unique.html | 1 + .../help-v4/en-US/aria_region_labelled.html | 3 ++- .../help-v4/en-US/aria_search_label_unique.html | 1 + .../src/v4/rules/aria_application_labelled.ts | 4 ++-- .../src/v4/rules/aria_complementary_label_visible.ts | 2 +- .../src/v4/rules/aria_complementary_labelled.ts | 4 ++-- .../src/v4/rules/aria_document_label_unique.ts | 4 ++-- .../src/v4/rules/aria_landmark_name_unique.ts | 10 +++++----- .../src/v4/rules/aria_main_label_unique.ts | 2 +- .../src/v4/rules/aria_parent_required.ts | 4 ++-- .../src/v4/rules/aria_region_label_unique.ts | 2 +- .../src/v4/rules/aria_region_labelled.ts | 6 +++--- 25 files changed, 40 insertions(+), 22 deletions(-) diff --git a/accessibility-checker-engine/help-v4/en-US/aria_application_label_unique.html b/accessibility-checker-engine/help-v4/en-US/aria_application_label_unique.html index a27730a88..9ebc32c97 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_application_label_unique.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_application_label_unique.html @@ -82,6 +82,7 @@

Weather portlet

* [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) * [ARIA6: aria-label to label objects](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA6) * [ARIA13: aria-labelledby to name regions and landmarks](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA13) +* [ARIA specification - Application Role](https://www.w3.org/TR/wai-aria-1.2/#application) ### Who does this affect? diff --git a/accessibility-checker-engine/help-v4/en-US/aria_application_labelled.html b/accessibility-checker-engine/help-v4/en-US/aria_application_labelled.html index 843c1487c..45e18169c 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_application_labelled.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_application_labelled.html @@ -79,6 +79,7 @@

Weather portlet

* [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) * [ARIA practices - Accessible Names and Descriptions](https://www.w3.org/WAI/ARIA/apg/practices/names-and-descriptions/) +* [ARIA specification - Application Role](https://www.w3.org/TR/wai-aria-1.2/#application) ### Who does this affect? diff --git a/accessibility-checker-engine/help-v4/en-US/aria_article_label_unique.html b/accessibility-checker-engine/help-v4/en-US/aria_article_label_unique.html index 3a8dc7da8..72edce742 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_article_label_unique.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_article_label_unique.html @@ -83,6 +83,7 @@

Stock Ticker Portlet * [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) * [ARIA6: aria-label to label objects](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA6) * [ARIA13: aria-labelledby to name regions and landmarks](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA13) +* [ARIA specification - Article Role](https://www.w3.org/TR/wai-aria-1.2/#article) ### Who does this affect? diff --git a/accessibility-checker-engine/help-v4/en-US/aria_banner_label_unique.html b/accessibility-checker-engine/help-v4/en-US/aria_banner_label_unique.html index d22157c79..9c3208c4f 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_banner_label_unique.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_banner_label_unique.html @@ -83,6 +83,7 @@

Weather portlet

* [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) * [ARIA6: aria-label to label objects](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA6) * [ARIA13: aria-labelledby to name regions and landmarks](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA13) +* [ARIA specification - Banner Role](https://www.w3.org/TR/wai-aria-1.2/#banner)] ### Who does this affect? diff --git a/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_unique.html b/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_unique.html index 1867efa1d..61ebe6ef9 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_unique.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_unique.html @@ -82,6 +82,7 @@

Weather portlet

* [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) * [ARIA6: aria-label to label objects](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA6) * [ARIA13: aria-labelledby to name regions and landmarks](https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA13) +* [ARIA specification - Complementary Role](https://www.w3.org/TR/wai-aria-1.2/#complementary) ### Who does this affect? diff --git a/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_visible.html b/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_visible.html index 777148ff5..7605e3a5e 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_visible.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_complementary_label_visible.html @@ -79,6 +79,7 @@

Weather portlet

* [IBM 2.4.1 Bypass Blocks](https://www.ibm.com/able/requirements/requirements/#2_4_1) * [ARIA specification - complementary role](https://www.w3.org/TR/wai-aria-1.2/#complementary) * [ARIA practices - Landmark Regions](https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/) +* [ARIA specification - Complementary Role](https://www.w3.org/TR/wai-aria-1.2/#complementary) ### Who does this affect? diff --git a/accessibility-checker-engine/help-v4/en-US/aria_contentinfo_label_unique.html b/accessibility-checker-engine/help-v4/en-US/aria_contentinfo_label_unique.html index 9b47d704e..afdffc649 100644 --- a/accessibility-checker-engine/help-v4/en-US/aria_contentinfo_label_unique.html +++ b/accessibility-checker-engine/help-v4/en-US/aria_contentinfo_label_unique.html @@ -44,7 +44,10 @@