Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit text_block_heading rule to fix issues #2037

Closed
shunguoy opened this issue Sep 12, 2024 · 1 comment
Closed

Revisit text_block_heading rule to fix issues #2037

shunguoy opened this issue Sep 12, 2024 · 1 comment
Labels
engine Issues in the accessibility-checker-engine component T63

Comments

@shunguoy
Copy link
Contributor

shunguoy commented Sep 12, 2024

This rule applies to the DOM elements p, div, and br. The issues are:
(1) The br is usually just a line break without any child (Content model: Nothing), such as
or
.
(2) other elements should be considered: strong, em etc.
(3) the test case results are wrong, such as test/v2/checker/accessibility/rules/text_block_heading_ruleunit/Headings-noneUsedEmphasizedText.html. which shouldn't report errors in
elements that have no child.

@shunguoy shunguoy added T63 engine Issues in the accessibility-checker-engine component labels Sep 12, 2024
@shunguoy
Copy link
Contributor Author

Triage: we are looking at the block level elements only with new lines, rather than individual text sections.

@philljenkins philljenkins mentioned this issue Nov 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues in the accessibility-checker-engine component T63
Projects
None yet
Development

No branches or pull requests

1 participant