Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: In Firefox, selecting "learn more" only opens an elements first issue. #2002

Closed
YoshiJL opened this issue Aug 16, 2024 · 3 comments · Fixed by #2018
Closed

[BUG]: In Firefox, selecting "learn more" only opens an elements first issue. #2002

YoshiJL opened this issue Aug 16, 2024 · 3 comments · Fixed by #2018
Assignees
Labels
Bug Something isn't working extension-checker Issues related to the browser extensions user-reported Issues identified outside of the core team

Comments

@YoshiJL
Copy link

YoshiJL commented Aug 16, 2024

Project

accessibility-checker-engine, extension-checker

Browser

Firefox

Operating system

Windows

Description

When an element has multiple issues, selecting "Learn more" will only open the first issue, even if the issue you selected isn't the first one in the list.

Steps to reproduce

  1. Complete a scan.
  2. Find an element that has multiple issues.
  3. Go to an element's second issue.
  4. Select "Learn more".
  5. The panel that appears shows information for the first issue.
@MHoov MHoov added Bug Something isn't working user-reported Issues identified outside of the core team extension-checker Issues related to the browser extensions labels Aug 16, 2024
@tombrunet
Copy link
Member

Confirmed in Firefox. Note that this works fine on Chrome, so it's only failing on Firefox.

@MHoov
Copy link

MHoov commented Aug 19, 2024

@drjoho can you get Namrata started on this bug? Tom is adding her to GH.

@marcjohlic marcjohlic changed the title [BUG]: In Firefox, seleting "learn more" only opens an elements first issue. [BUG]: In Firefox, selecting "learn more" only opens an elements first issue. Aug 22, 2024
@drjoho
Copy link
Contributor

drjoho commented Aug 23, 2024

@nam-singh Note that if you click the issue if you have enough room on the screen the Help / Learn more will show up correctly on any issue. The problem only occurs when you actually click the Learn more link.

One file to check is reportTreeGrid.tsx the onClick for the Learn more is as follows:
onClick={() => {
this.onRow(group, thisIssue);
ReportTreeGrid.devtoolsAppController.setSecondaryView("help");
ReportTreeGrid.devtoolsAppController.openSecondary(#${rowId} a);
}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working extension-checker Issues related to the browser extensions user-reported Issues identified outside of the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants