Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: input_haspopup_conflict needs updating #1915

Closed
1 task done
philljenkins opened this issue Jun 3, 2024 · 5 comments · Fixed by #1917
Closed
1 task done

Help: input_haspopup_conflict needs updating #1915

philljenkins opened this issue Jun 3, 2024 · 5 comments · Fixed by #1917
Assignees
Labels
Ready for QA SME Discuss with subject matter experts T62

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Jun 3, 2024

See box note discussion: Checker rule box note

  • 5. Help: add more valid types to list in Help, or change Help to point the spec’s list of valid types in HTML and ARIA

input_haspopup_conflict.html Help currently says:
...

What to do

  • Remove the aria-haspopup attribute from the <input> element that has a list attribute with input type=
    text,
    search,
    tel,
    url,
    or email,
    etc. per HTML and ARIA specifications
  • And/Or, add an valid input type if missing or correct the invalid input type.

There should be more listed above per HTML and ARIA specs or links to the specs:

About this requirement

@philljenkins philljenkins self-assigned this Jun 3, 2024
@shunguoy shunguoy added T62 SME Discuss with subject matter experts labels Jun 4, 2024
@shunguoy
Copy link
Contributor

shunguoy commented Jun 4, 2024

rule branch: dev-1622

@philljenkins
Copy link
Contributor Author

New input_haspopup_conflict rule logic that Help should support:

        let yesTypes = ["text", "search", "tel", "url", "email", "date", "month", "week", "time", "datetime-local", "number", "range", "color"];
        let noTypes = ["file", "password", "checkbox", "radio", "submit", "reset", "image", "hidden", "button"];

@philljenkins
Copy link
Contributor Author

Help was reorganized, simplified (removed redundancies and duplications), and now also includes all the input types

@philljenkins
Copy link
Contributor Author

Before:

Screenshot 2024-06-18 at 12 54 43 PM

After:

Screenshot 2024-06-18 at 12 52 49 PM

@philljenkins
Copy link
Contributor Author

@shunguoy Please review the Help for technical accuracy/feedback, if OK, then mark the PR ready for Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for QA SME Discuss with subject matter experts T62
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants