Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y_Bug]: Issue type counts should not be in tab order / clickable #1819

Closed
philljenkins opened this issue Jan 30, 2024 · 3 comments
Closed
Assignees
Labels
A11y_Bug Accessibility or usability issue extension-checker Issues related to the browser extensions priority-3 (low)

Comments

@philljenkins
Copy link
Contributor

Project

extension-checker

Browser

Chrome

Operating System

MacOS

Automated testing tool and ruleset

No response

Assistive technology

Keyboard

Description

The keyboard tab stops on the issue type/icon counts,
as if to say they are interactive, but they are not.
Pressing enter/space only shows the tooltip, confusing the keyboard user that there is some other action available because the tab stopped there. The tooltip should show when t receives keyboard focus, without needing to pres space/enter to show it. However, in this case, they shouldn't be in the tab order at all.
IssueTypeCounts

Steps to reproduce

  1. Open Checker
  2. Tab until focus arrives on 'issue type/icons' with counts
@philljenkins philljenkins added A11y_Bug Accessibility or usability issue extension-checker Issues related to the browser extensions priority-2 (med) labels Jan 30, 2024
@marcjohlic
Copy link
Member

marcjohlic commented Feb 6, 2024

Discussion with Marc, Tom, Mike, Josiah & Marnie - decision is to just remove the Definition ToolTip completely from these icons as we already have affordances for these in the QuickGuide, User Guide, and Issues Panel.

Action: Remove Definition ToolTip from these icons.

This can be worked on in conjunction with #1830 toobar reflow issue

@philljenkins
Copy link
Contributor Author

philljenkins commented Feb 6, 2024

@drjoho
JAWS 2024 currently reads the controls as follows, which is not correct.
Not using the tab key to navigate, but using the right arrow keys to reads the UI:
after scanning AltoroMutual
...

  • "Keyboard Checker Mode button - to activate press enter"
  • "Violation button collapsed - to activate press enter"
  • pressing Enter, JAWS says "expanded" and nothing else
  • continuing with right arrow key, JAWS will read the numbers one at a time, and then spell out "Violations" one letter at a time.
  • continuing instead with down arrow key, JAWS will correctly read the "blank", then "Violations" as a word, not character by character, but then reads (incorrectly) the number followed by a bunch of other numbers, control names, and states (collapsed).

I can check with JAWS again when you have a new PR/Action artifact. I did this testing with the latest PR 1820.

@drjoho
Copy link
Contributor

drjoho commented Feb 26, 2024

Deemed fixed in new UI

@drjoho drjoho closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y_Bug Accessibility or usability issue extension-checker Issues related to the browser extensions priority-3 (low)
Projects
None yet
Development

No branches or pull requests

3 participants