diff --git a/.github/ISSUE_TEMPLATE/accessibility_issue.yaml b/.github/ISSUE_TEMPLATE/accessibility_issue.yaml index 469ad7602..54d6988e4 100644 --- a/.github/ISSUE_TEMPLATE/accessibility_issue.yaml +++ b/.github/ISSUE_TEMPLATE/accessibility_issue.yaml @@ -51,7 +51,7 @@ body: - type: input id: tool attributes: - label: Automated testing tool and ruleset + label: Automated testing tool and ruleset. description: 'Which tool and ruleset uncovered the issue?' placeholder: e.g. IBM Equal Access Accessibility Checker - Latest Deployment - type: input @@ -77,4 +77,16 @@ body: 'How do we reproduce the accessibility violation you described?' validations: required: true - + - type: markdown + attributes: + value: | + ### Definition of Done + (DO NOT EDIT THIS SECTION. This section is for IBM internal use only.) + - [ ] Design artifacts reviewed + - [ ] Work item implemented + - [ ] Automated test case created (when applicable) + - [ ] Unit test completed + - [ ] Run Checker (when applicable) + - [ ] Manual and Screen Reader Testing (when applicable) + - [ ] Video recording of user experience walkthrough (if impact to UX) + - [ ] PR created diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 000000000..15f09726b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,50 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Desktop (please complete the following information):** + - OS: [e.g. iOS] + - Browser [e.g. chrome, safari] + - Version [e.g. 22] + +**Smartphone (please complete the following information):** + - Device: [e.g. iPhone6] + - OS: [e.g. iOS8.1] + - Browser [e.g. stock browser, safari] + - Version [e.g. 22] + +**Additional context** +Add any other context about the problem here. + + +## Definition of Done + +- [ ] Design artifacts reviewed +- [ ] Work item implemented +- [ ] Automated test case created (when applicable) +- [ ] Unit test completed +- [ ] Run Checker (when applicable) +- [ ] Manual and Screen Reader Testing (when applicable) +- [ ] Video recording of user experience walkthrough (if impact to UX) +- [ ] PR created diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index e8a5c32e9..ebf96ed25 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -63,4 +63,18 @@ body: 'How do we reproduce the issue you described using the?' validations: required: true + - type: markdown + attributes: + value: | + ### Definition of Done + (DO NOT EDIT THIS SECTION. This section is for IBM internal use only.) + - [ ] Design artifacts reviewed + - [ ] Work item implemented + - [ ] Automated test case created (when applicable) + - [ ] Unit test completed + - [ ] Run Checker (when applicable) + - [ ] Manual and Screen Reader Testing (when applicable) + - [ ] Video recording of user experience walkthrough (if impact to UX) + - [ ] PR created + diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d33bb1553..ed3d0015f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -23,6 +23,20 @@ - [ ] This PR has been reviewed and is ready for test - [ ] I understand that the title of this PR will be used for the next release notes. + +### Assets to aide review attached + +- [ ] Links to design artifacts +- [ ] Links to video walkthrough of user experience +- [ ] Other + +### Definition of Done + +- [ ] Peer review complete +- [ ] Secondary review complete +- [ ] Staging deployment verified + + \ No newline at end of file +--> diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 1a696f6f0..c1387b9d8 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -44,7 +44,7 @@ jobs: - run: npm run package:browser working-directory: accessibility-checker-extension - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: accessibility-checker-extension for Chrome path: accessibility-checker-extension/package/accessibility-checker-extension.zip @@ -53,7 +53,7 @@ jobs: - run: npm run package:browser working-directory: accessibility-checker-extension - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: accessibility-checker-extension for Firefox path: accessibility-checker-extension/package/accessibility-checker-extension.zip @@ -92,7 +92,7 @@ jobs: - run: npm test working-directory: accessibility-checker/test-act-w3 - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: ACT Text Results path: accessibility-checker/test-act-w3/act-report-v2.txt diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index effb8a43e..98fe09d6c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -173,7 +173,7 @@ jobs: - run: npm run package:browser working-directory: accessibility-checker-extension - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: accessibility-checker-extension for Chrome path: accessibility-checker-extension/package/accessibility-checker-extension.zip @@ -195,7 +195,7 @@ jobs: - run: npm run package:browser working-directory: accessibility-checker-extension - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: accessibility-checker-extension for Firefox path: accessibility-checker-extension/package/accessibility-checker-extension.zip @@ -222,4 +222,46 @@ jobs: BLUEMIX_USERID: apikey BLUEMIX_PASS: ${{ secrets.BLUEMIX_PASS }} CLOUD_PWD: ${{ secrets.CLOUD_PWD }} - TRAVIS_BRANCH: prod \ No newline at end of file + TRAVIS_BRANCH: prod + + java-accessibility-checker-deploy: + runs-on: ubuntu-22.04 + permissions: + packages: write + strategy: + matrix: + node-version: [18.x] + + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-java@v4 + with: + distribution: 'semeru' # See 'Supported distributions' for available options + java-version: '17' + server-id: central + server-username: ${{ secrets.MVN_GITHUB_USER }} + server-password: ${{ secrets.MVN_GITHUB_TOKEN }} + - uses: s4u/maven-settings-action@v3.0.0 + with: + servers: | + [{ + "id": "central", + "username": "${{ secrets.MVN_GITHUB_USER }}", + "password": "${{ secrets.MVN_GITHUB_TOKEN }}" + }] + - name: Configure GPG Key + run: echo "$GPG_SIGNING_KEY" >private.key + env: + GPG_SIGNING_KEY: ${{ secrets.GPG_SIGNING_KEY }} + - name: Import GPG Key + run: gpg --pinentry-mode=loopback --passphrase "$GPG_SIGNING_KEY_PASS" --import private.key + env: + GPG_SIGNING_KEY_PASS: ${{ secrets.GPG_SIGNING_KEY_PASS }} + - name: Set version + run: sed -i'.old' -e 's/3\.0\.0<\/version>/'"${GITHUB_REF:10}"'<\/version>/g' ./pom.xml + working-directory: java-accessibility-checker + - name: Publish package + run: mvn --batch-mode deploy -DskipTests -Dgpg.passphrase=$GPG_SIGNING_KEY_PASS + working-directory: java-accessibility-checker + env: + GPG_SIGNING_KEY_PASS: ${{ secrets.GPG_SIGNING_KEY_PASS }} \ No newline at end of file diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 29c08a6dd..6ed2cbd4f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -42,10 +42,15 @@ jobs: - run: npx mocha ./test/mocha/help/help.test.js working-directory: accessibility-checker-engine - name: Upload rule listing - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: Rule listing path: accessibility-checker-engine/dist/help/rules.html + - name: Upload rule mapping spreadsheet + uses: actions/upload-artifact@v4 + with: + name: Rule mapping spreadsheet + path: accessibility-checker-engine/dist/help/rules.csv act-results: @@ -84,7 +89,7 @@ jobs: - run: npm test working-directory: accessibility-checker/test-act-w3 - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: ACT Text Results path: accessibility-checker/test-act-w3/act-report-v2.txt @@ -361,6 +366,77 @@ jobs: - run: npm run wdio working-directory: accessibility-checker/test/webdriverio +############################################################################### +# Java test +#### + java-accessibility-checker-selenium-test: + runs-on: ubuntu-22.04 + + strategy: + matrix: + node-version: [18.x] + + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-java@v4 + with: + distribution: 'semeru' # See 'Supported distributions' for available options + java-version: '17' + - name: Latest Chrome + uses: browser-actions/setup-chrome@v1 + with: + chrome-version: latest + install-chromedriver: true + id: setup-chrome + - run: npm install + working-directory: rule-server + - run: npm run build + working-directory: rule-server + - run: node main.js & + working-directory: rule-server/dist + - run: sleep 10 + working-directory: rule-server/dist + - name: Test package + run: mvn --batch-mode test -Dtest="AccessibilityCheckerSeleniumTest" + working-directory: java-accessibility-checker + env: + chromedriverpath: ${{ steps.setup-chrome.outputs.chromedriver-path }} + chromebinpath: ${{ steps.setup-chrome.outputs.chrome-path }} + + java-accessibility-checker-playwright-test: + runs-on: ubuntu-22.04 + + strategy: + matrix: + node-version: [18.x] + + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-java@v4 + with: + distribution: 'semeru' # See 'Supported distributions' for available options + java-version: '17' + - name: Latest Chrome + uses: browser-actions/setup-chrome@v1 + with: + chrome-version: latest + install-chromedriver: true + id: setup-chrome + - run: npm install + working-directory: rule-server + - run: npm run build + working-directory: rule-server + - run: node main.js & + working-directory: rule-server/dist + - run: sleep 10 + working-directory: rule-server/dist + - name: Test package + run: mvn --batch-mode test -Dtest="AccessibilityCheckerPlaywrightTest" + working-directory: java-accessibility-checker + env: + chromedriverpath: ${{ steps.setup-chrome.outputs.chromedriver-path }} + chromebinpath: ${{ steps.setup-chrome.outputs.chrome-path }} + ############################################################################### # Karma Tests #### @@ -491,7 +567,7 @@ jobs: run: npm test working-directory: accessibility-checker-extension/test - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: accessibility-checker-extension for Chrome path: accessibility-checker-extension/package/accessibility-checker-extension.zip @@ -500,7 +576,7 @@ jobs: - run: npm run package:browser working-directory: accessibility-checker-extension - name: Upload packed extension - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v4 with: name: accessibility-checker-extension for Firefox path: accessibility-checker-extension/package/accessibility-checker-extension.zip diff --git a/accessibility-checker-engine/help-v4/en-US/label_ref_valid.html b/accessibility-checker-engine/help-v4/en-US/label_ref_valid.html index ecbed3f1c..49f858faf 100644 --- a/accessibility-checker-engine/help-v4/en-US/label_ref_valid.html +++ b/accessibility-checker-engine/help-v4/en-US/label_ref_valid.html @@ -45,8 +45,8 @@

### Why is this important? -A `